Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

endTime from ISO string, get items from Firebase data (not local data), and some small tweaks #30

Merged
merged 5 commits into from
Apr 25, 2023

Conversation

hmellor
Copy link
Owner

@hmellor hmellor commented Apr 25, 2023

  • Item data, generateRandomItemData and generateItems moves to items.js
  • items[i].endTime now specified using ISO 8601 format (much more human readable than epoch millis)
  • endTime sent to Firestore in TimeStamp format for ease of viewing in Firebase console
  • All clocks now triggered using setInterval instead of setTimer & recursion
  • Timer will show 10ths of a second when there's less than 10 minutes left (for excitement reasons)

@hmellor hmellor merged commit ce7f8d5 into main Apr 25, 2023
@hmellor hmellor deleted the friendly-end-time-format branch April 25, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant