Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the sphinx docs #135

Merged
merged 13 commits into from
Nov 3, 2020
Merged

Improve the sphinx docs #135

merged 13 commits into from
Nov 3, 2020

Conversation

hmpf
Copy link
Owner

@hmpf hmpf commented Oct 6, 2020

No description provided.

@hmpf hmpf added the documentation Enhancment/bug in the documentation label Oct 6, 2020
@hmpf
Copy link
Owner Author

hmpf commented Oct 6, 2020

These terms need to be indexed.

@hmpf hmpf mentioned this pull request Oct 6, 2020
@adilhasan adilhasan marked this pull request as ready for review October 6, 2020 13:29
@hmpf
Copy link
Owner Author

hmpf commented Oct 7, 2020

Indexed by switching turning the list into a glossary.

@hmpf hmpf changed the title Add a page with terminology Improve the sphinx docs Oct 7, 2020
Copy link
Collaborator

@adilhasan adilhasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Hanne,
it's a bit complicated. Aren't all questions associated to a section? So, I can't understand the distinction between optional question and optional section question. I wonder if we could simplify a little bit? I mean we could have optional X where X could be a question or section? I think getting all the terms down is valuable. Maybe we can rationalise it a bit

docs/terminology.rst Outdated Show resolved Hide resolved
@hmpf
Copy link
Owner Author

hmpf commented Oct 15, 2020

Hello Hanne,
it's a bit complicated. Aren't all questions associated to a section? So, I can't understand the distinction between optional question and optional section question. I wonder if we could simplify a little bit? I mean we could have optional X where X could be a question or section? I think getting all the terms down is valuable. Maybe we can rationalise it a bit

Are you talking about the terminology list? "optional question" and "optional section question" are not the same thing. "optional section question" makes an entire section optional.

@adilhasan
Copy link
Collaborator

So, maybe we need to improve the terminology list as I think it's quite subtle. Does the optional section question address the case where I would want to want to make an entire section optional. Ie "For this submission, users must fill in sections 1, 3, 4. Sections 2 and 5 are optional for this submission."?

@hmpf
Copy link
Owner Author

hmpf commented Oct 15, 2020

Does the optional section question address the case where I would want to want to make an entire section optional. Ie "For this submission, users must fill in sections 1, 3, 4. Sections 2 and 5 are optional for this submission."?

Yes, exactly. It's magical BooleanQuestion and an implementation detail, but we need to document it somewhere and agree on terminology for it.

Copy link
Collaborator

@adilhasan adilhasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Hanne, sorry for the delay in getting back to you on this. It seems to me to be fine.
hth adil

@codecov
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #135 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #135   +/-   ##
=======================================
  Coverage   61.01%   61.01%           
=======================================
  Files         110      110           
  Lines        6718     6718           
=======================================
  Hits         4099     4099           
  Misses       2619     2619           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c7e348...9be6969. Read the comment docs.

@hmpf hmpf merged commit b2d89a8 into master Nov 3, 2020
@hmpf hmpf deleted the improve-docs branch November 3, 2020 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Enhancment/bug in the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants