APID-497 - Upgrade to hmrc-mongo repo #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worthydolt
reviewed
Jul 4, 2022
project/AppDependencies.scala
Outdated
| @@ -7,22 +7,24 @@ object AppDependencies { | |||
| lazy val dependencyOverrides = overrides | |||
|
|
|||
| private lazy val bootstrapVersion = "5.16.0" | |||
| private lazy val hmrcReactiveMongoTestVersion = "5.0.0-play-28" | |||
| private lazy val hmrcMongoTestVersion = "0.64.0" | |||
| private lazy val hmrcMongoVersion = "0.64.0" | |||
| private lazy val scalaJVersion = "2.4.2" | |||
| private lazy val scalatestPlusPlayVersion = "4.0.0" | |||
| // we need to override the akka version for now as newer versions are not compatible with reactivemongo | |||
| private lazy val akkaVersion = "2.6.14" | |||
There was a problem hiding this comment.
Is this necessary given it was added to overcome an incompatibility with reactivemongo
project/AppDependencies.scala
Outdated
| @@ -7,22 +7,24 @@ object AppDependencies { | |||
| lazy val dependencyOverrides = overrides | |||
|
|
|||
| private lazy val bootstrapVersion = "5.16.0" | |||
There was a problem hiding this comment.
Please update to latest found in the catalogue
| val scope1 = Scope("key1", "name1", "description1") | ||
| val scope2 = Scope("key2", "name2", "description2", confidenceLevel = Some(L200)) | ||
| def repo: ScopeRepository = app.injector.instanceOf[ScopeRepository] |
There was a problem hiding this comment.
Shouldn't need to inject this twice
|
|
||
| class ScopeRepositorySpec extends AsyncHmrcSpec | ||
| with BeforeAndAfterEach with BeforeAndAfterAll | ||
| with MongoSpecSupport | ||
| with CleanMongoCollectionSupport |
There was a problem hiding this comment.
This is already brought in by DefaultPlayMongoRepositorySupport
|
|
||
| override protected def afterAll() { | ||
| dropRepository(repository) | ||
| super.beforeEach() |
There was a problem hiding this comment.
appears to duplicate what's in the MongoApp trait
| } | ||
|
|
||
| def dropMongoDb(): Unit = | ||
| mongoDatabase.drop() |
There was a problem hiding this comment.
This is provided by MongoSupport trait
worthydolt
approved these changes
Jul 6, 2022
build.sbt
Outdated
| @@ -33,7 +33,6 @@ lazy val microservice = Project(appName, file(".")) | |||
| targetJvm := "jvm-1.8", | |||
| scalaVersion := "2.12.12", | |||
There was a problem hiding this comment.
Regrettable that this is repeated but nevertheless it would be preferable for it to match the version on line 14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.