-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APID-497 - Upgrade to hmrc-mongo repo #58
Conversation
project/AppDependencies.scala
Outdated
@@ -7,22 +7,24 @@ object AppDependencies { | |||
lazy val dependencyOverrides = overrides | |||
|
|||
private lazy val bootstrapVersion = "5.16.0" | |||
private lazy val hmrcReactiveMongoTestVersion = "5.0.0-play-28" | |||
private lazy val hmrcMongoTestVersion = "0.64.0" | |||
private lazy val hmrcMongoVersion = "0.64.0" | |||
private lazy val scalaJVersion = "2.4.2" | |||
private lazy val scalatestPlusPlayVersion = "4.0.0" | |||
// we need to override the akka version for now as newer versions are not compatible with reactivemongo | |||
private lazy val akkaVersion = "2.6.14" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary given it was added to overcome an incompatibility with reactivemongo
project/AppDependencies.scala
Outdated
@@ -7,22 +7,24 @@ object AppDependencies { | |||
lazy val dependencyOverrides = overrides | |||
|
|||
private lazy val bootstrapVersion = "5.16.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update to latest found in the catalogue
val scope1 = Scope("key1", "name1", "description1") | ||
val scope2 = Scope("key2", "name2", "description2", confidenceLevel = Some(L200)) | ||
def repo: ScopeRepository = app.injector.instanceOf[ScopeRepository] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't need to inject this twice
|
||
class ScopeRepositorySpec extends AsyncHmrcSpec | ||
with BeforeAndAfterEach with BeforeAndAfterAll | ||
with MongoSpecSupport | ||
with CleanMongoCollectionSupport |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already brought in by DefaultPlayMongoRepositorySupport
|
||
override protected def afterAll() { | ||
dropRepository(repository) | ||
super.beforeEach() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
appears to duplicate what's in the MongoApp
trait
} | ||
|
||
def dropMongoDb(): Unit = | ||
mongoDatabase.drop() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is provided by MongoSupport
trait
build.sbt
Outdated
@@ -33,7 +33,6 @@ lazy val microservice = Project(appName, file(".")) | |||
targetJvm := "jvm-1.8", | |||
scalaVersion := "2.12.12", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regrettable that this is repeated but nevertheless it would be preferable for it to match the version on line 14
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed it too
No description provided.