[TRDT-773] [CK] Remove warning suppression annotation. #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basotia
reviewed
Mar 31, 2023
app/uk/gov/hmrc/selfassessmentassist/v1/models/auth/UserDetails.scala
Outdated
Show resolved
Hide resolved
sudoku007
force-pushed
the
TRDT-773
branch
3 times, most recently
from
71f6deb
to
eb302ca
Compare
basotia
reviewed
Apr 28, 2023
| private def customerTypeString(customerType: CustomerType) = customerType match { | ||
| case TaxPayer => "Individual" | ||
| case Agent => "Agent" | ||
| case _ => "Agent" |
There was a problem hiding this comment.
I guess we should throw exception here as well case _ => throw new IllegalStateException(s"Invalid $customerType")
basotia
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.