Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No league details in tab[BUG] #1455

Closed
cheilson opened this issue Apr 14, 2022 · 5 comments
Closed

No league details in tab[BUG] #1455

cheilson opened this issue Apr 14, 2022 · 5 comments
Assignees
Labels
reso: CHPP Resolution requires CHPP changes reso: week 16 the issue only appears during interseason (week 16) status: needs test might be fixed, needs test before closing
Milestone

Comments

@cheilson
Copy link

Describe the bug
League tab is empty, can't get the league to show.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'LEAGUE tab'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Screenshots
https://ibb.co/2yhq97D

Platform information:

  • Win 11 home, 21H2
  • HO 6.0 DEV (r270)

Additional context
Add any other context about the problem here.

@wsbrenk
Copy link
Collaborator

wsbrenk commented Apr 15, 2022

@cheilson this seems to be a problem after the very first download. Did it remain when you download again (F11)?

@cheilson
Copy link
Author

Yes, it persists. I tried checking and unchecking everything at download window.

@cheilson
Copy link
Author

And now the league tab is full. Funny, I did nothing different.

@masterpatje
Copy link

@cheilson this seems to be a problem after the very first download. Did it remain when you download again (F11)?

@wsbrenk you fixed it on the very first download. It had to do with no matches yet present in the off-season. As soon as the first match of the league is played everything works perfectly also on the very first download.

Suggestion was to see if League Details (teams) can be subtracted from .hrf file from league ID (if available?), so that even when no matches are played the League Table can be shown as soon as the new league (and league teams are visible in hattrick).

But I think you already answered that one, that information is not available in .hrf to subtract that League data and that the data for the league is substracted from the matches. But correct me if I am wrong.

@wsbrenk
Copy link
Collaborator

wsbrenk commented Apr 15, 2022

that's right - just looked if there is a chance to do it the way @masterpatje suggests, but unfortunately ht (chpp) provides the information of the participating teams only when the games are fixed. So there are some weeks at the beginning of a new season without any information about the teams in the league.

@wsbrenk wsbrenk added the reso: CHPP Resolution requires CHPP changes label Apr 15, 2022
@wsbrenk wsbrenk added this to the 7.0 milestone May 25, 2022
@wsbrenk wsbrenk added the reso: week 16 the issue only appears during interseason (week 16) label Dec 18, 2022
@wsbrenk wsbrenk modified the milestones: 7.0, 8.0 Jan 30, 2023
@wsbrenk wsbrenk modified the milestones: 8.0, 9.0 Dec 10, 2023
@wsbrenk wsbrenk modified the milestones: 9.0, 8.0 May 26, 2024
wsbrenk added a commit to wsbrenk/HO that referenced this issue May 26, 2024
wsbrenk added a commit to wsbrenk/HO that referenced this issue May 26, 2024
wsbrenk added a commit to wsbrenk/HO that referenced this issue May 26, 2024
wsbrenk added a commit to wsbrenk/HO that referenced this issue May 26, 2024
@wsbrenk wsbrenk self-assigned this May 27, 2024
wsbrenk added a commit to wsbrenk/HO that referenced this issue Jun 1, 2024
wsbrenk added a commit to wsbrenk/HO that referenced this issue Jun 1, 2024
wsbrenk added a commit to wsbrenk/HO that referenced this issue Jun 1, 2024
wsbrenk added a commit to wsbrenk/HO that referenced this issue Jun 2, 2024
wsbrenk added a commit that referenced this issue Jun 6, 2024
* #2069 reduce space between team summary labels

* #2069 release_notes.md

* #1455 initialize series table if no matches are played yet

* #1455 fix initial order of series table

* #1455 review

* #1455 review

* #1455 review

* #1455 review

* #1455 review
@wsbrenk wsbrenk added the status: needs test might be fixed, needs test before closing label Jun 6, 2024
wsbrenk added a commit that referenced this issue Jun 6, 2024
* #1455 review

* #2074 update ratings when team spirit is changed
wsbrenk added a commit that referenced this issue Jun 6, 2024
* #1797 create beta (#2052)

* Fix build (#2054)

* #1797 create beta

* #1797 fix build

* #2055 fix slow opening of team analyzer panel (#2056)

* update release_notes.md

* #2055 remove unused info label

* #2055 remove unused info label (code analysis results)

* #2055 release_notes.md

* #2055 release_notes.md

* Use SwingWorker to properly fix hanging UI. (#2057)

* Update dependencies, in particular OkHttp to fix CVE. (#2058)

This fixes CVE-2023-3635, cf. https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-3635

* #2059 fix currency error in team analyzer's total salary column (#2060)

* #2063 add 5 new countries to international flags module (#2064)

* #2063 add 5 new countries to international flags module

* #2063 add 5 new countries to international flags module (review)

* release_notes.md translator

* #2063 the flag files

* #2065 truncate match report if string is too long for database column (#2066)

* #2065 truncate match report if string is too long for database column

* #2065 rename AbstractTable.truncateString

* #2063 Guinea (#2068)

* #2063 download missing world details (#2070)

* #2063 download missing world details

* #2063 download missing world details

* #2063 download missing world details

* #2063 fix database error on matches reload

* #2069 (#2072)

* #2069 reduce space between team summary labels

* #2069 release_notes.md

* #1455 Initialize series table if no matches are played yet (#2073)

* #2069 reduce space between team summary labels

* #2069 release_notes.md

* #1455 initialize series table if no matches are played yet

* #1455 fix initial order of series table

* #1455 review

* #1455 review

* #1455 review

* #1455 review

* #1455 review

* #2074 update ratings when team spirit is changed (#2075)

* #1455 review

* #2074 update ratings when team spirit is changed

* #2076 sorting of youth table average column (#2077)

* #2078 ts forecast loads all trainer data (#2079)

* #2078 ts forecast loads all trainer data

* #2078 release_notes.md

---------

Co-authored-by: Sébastien Le Callonnec <sebastien@weblogism.com>
@wsbrenk wsbrenk closed this as completed Jun 22, 2024
wsbrenk added a commit that referenced this issue Jun 23, 2024
* #1797 create beta (#2052)

* Fix build (#2054)

* #1797 create beta

* #1797 fix build

* #2055 fix slow opening of team analyzer panel (#2056)

* update release_notes.md

* #2055 remove unused info label

* #2055 remove unused info label (code analysis results)

* #2055 release_notes.md

* #2055 release_notes.md

* Use SwingWorker to properly fix hanging UI. (#2057)

* Update dependencies, in particular OkHttp to fix CVE. (#2058)

This fixes CVE-2023-3635, cf. https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-3635

* #2059 fix currency error in team analyzer's total salary column (#2060)

* #2063 add 5 new countries to international flags module (#2064)

* #2063 add 5 new countries to international flags module

* #2063 add 5 new countries to international flags module (review)

* release_notes.md translator

* #2063 the flag files

* #2065 truncate match report if string is too long for database column (#2066)

* #2065 truncate match report if string is too long for database column

* #2065 rename AbstractTable.truncateString

* #2063 Guinea (#2068)

* #2063 download missing world details (#2070)

* #2063 download missing world details

* #2063 download missing world details

* #2063 download missing world details

* #2063 fix database error on matches reload

* #2069 (#2072)

* #2069 reduce space between team summary labels

* #2069 release_notes.md

* #1455 Initialize series table if no matches are played yet (#2073)

* #2069 reduce space between team summary labels

* #2069 release_notes.md

* #1455 initialize series table if no matches are played yet

* #1455 fix initial order of series table

* #1455 review

* #1455 review

* #1455 review

* #1455 review

* #1455 review

* #2074 update ratings when team spirit is changed (#2075)

* #1455 review

* #2074 update ratings when team spirit is changed

* #2076 sorting of youth table average column (#2077)

* #2078 ts forecast loads all trainer data (#2079)

* #2078 ts forecast loads all trainer data

* #2078 release_notes.md

* Create `stable` tag when `tag_stable` is created. (#2083) (#2085)

* Release/8 (#2084)

* Create `stable` tag when `tag_stable` is created.

* release stable HO8

* release stable HO8

---------

Co-authored-by: Sébastien Le Callonnec <sebastien@weblogism.com>

---------

Co-authored-by: Sébastien Le Callonnec <sebastien@weblogism.com>
wsbrenk added a commit that referenced this issue Jun 23, 2024
* #1797 create beta (#2052)

* Fix build (#2054)

* #1797 create beta

* #1797 fix build

* #2055 fix slow opening of team analyzer panel (#2056)

* update release_notes.md

* #2055 remove unused info label

* #2055 remove unused info label (code analysis results)

* #2055 release_notes.md

* #2055 release_notes.md

* Use SwingWorker to properly fix hanging UI. (#2057)

* Update dependencies, in particular OkHttp to fix CVE. (#2058)

This fixes CVE-2023-3635, cf. https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-3635

* #2059 fix currency error in team analyzer's total salary column (#2060)

* #2063 add 5 new countries to international flags module (#2064)

* #2063 add 5 new countries to international flags module

* #2063 add 5 new countries to international flags module (review)

* release_notes.md translator

* #2063 the flag files

* #2065 truncate match report if string is too long for database column (#2066)

* #2065 truncate match report if string is too long for database column

* #2065 rename AbstractTable.truncateString

* #2063 Guinea (#2068)

* #2063 download missing world details (#2070)

* #2063 download missing world details

* #2063 download missing world details

* #2063 download missing world details

* #2063 fix database error on matches reload

* #2069 (#2072)

* #2069 reduce space between team summary labels

* #2069 release_notes.md

* #1455 Initialize series table if no matches are played yet (#2073)

* #2069 reduce space between team summary labels

* #2069 release_notes.md

* #1455 initialize series table if no matches are played yet

* #1455 fix initial order of series table

* #1455 review

* #1455 review

* #1455 review

* #1455 review

* #1455 review

* #2074 update ratings when team spirit is changed (#2075)

* #1455 review

* #2074 update ratings when team spirit is changed

* #2076 sorting of youth table average column (#2077)

* #2078 ts forecast loads all trainer data (#2079)

* #2078 ts forecast loads all trainer data

* #2078 release_notes.md

* Create `stable` tag when `tag_stable` is created. (#2083) (#2085)

* Release/8 (#2084)

* Create `stable` tag when `tag_stable` is created.

* release stable HO8

* release stable HO8

---------

Co-authored-by: Sébastien Le Callonnec <sebastien@weblogism.com>

* release stable HO8

* release stable HO8

---------

Co-authored-by: Sébastien Le Callonnec <sebastien@weblogism.com>
wsbrenk added a commit that referenced this issue Jul 4, 2024
* #1797 create beta (#2052)

* Fix build (#2054)

* #1797 create beta

* #1797 fix build

* #2055 fix slow opening of team analyzer panel (#2056)

* update release_notes.md

* #2055 remove unused info label

* #2055 remove unused info label (code analysis results)

* #2055 release_notes.md

* #2055 release_notes.md

* Use SwingWorker to properly fix hanging UI. (#2057)

* Update dependencies, in particular OkHttp to fix CVE. (#2058)

This fixes CVE-2023-3635, cf. https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-3635

* #2059 fix currency error in team analyzer's total salary column (#2060)

* #2063 add 5 new countries to international flags module (#2064)

* #2063 add 5 new countries to international flags module

* #2063 add 5 new countries to international flags module (review)

* release_notes.md translator

* #2063 the flag files

* #2065 truncate match report if string is too long for database column (#2066)

* #2065 truncate match report if string is too long for database column

* #2065 rename AbstractTable.truncateString

* #2063 Guinea (#2068)

* #2063 download missing world details (#2070)

* #2063 download missing world details

* #2063 download missing world details

* #2063 download missing world details

* #2063 fix database error on matches reload

* #2069 (#2072)

* #2069 reduce space between team summary labels

* #2069 release_notes.md

* #1455 Initialize series table if no matches are played yet (#2073)

* #2069 reduce space between team summary labels

* #2069 release_notes.md

* #1455 initialize series table if no matches are played yet

* #1455 fix initial order of series table

* #1455 review

* #1455 review

* #1455 review

* #1455 review

* #1455 review

* #2074 update ratings when team spirit is changed (#2075)

* #1455 review

* #2074 update ratings when team spirit is changed

* #2076 sorting of youth table average column (#2077)

* #2078 ts forecast loads all trainer data (#2079)

* #2078 ts forecast loads all trainer data

* #2078 release_notes.md

* Create `stable` tag when `tag_stable` is created. (#2083) (#2085)

* Release/8 (#2084)

* Create `stable` tag when `tag_stable` is created.

* release stable HO8

* release stable HO8

---------

Co-authored-by: Sébastien Le Callonnec <sebastien@weblogism.com>

* #2094 youth scout comment column length

---------

Co-authored-by: Sébastien Le Callonnec <sebastien@weblogism.com>
wsbrenk added a commit that referenced this issue Jul 6, 2024
* #1797 create beta (#2052)

* Fix build (#2054)

* #1797 create beta

* #1797 fix build

* #2055 fix slow opening of team analyzer panel (#2056)

* update release_notes.md

* #2055 remove unused info label

* #2055 remove unused info label (code analysis results)

* #2055 release_notes.md

* #2055 release_notes.md

* Use SwingWorker to properly fix hanging UI. (#2057)

* Update dependencies, in particular OkHttp to fix CVE. (#2058)

This fixes CVE-2023-3635, cf. https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-3635

* #2059 fix currency error in team analyzer's total salary column (#2060)

* #2063 add 5 new countries to international flags module (#2064)

* #2063 add 5 new countries to international flags module

* #2063 add 5 new countries to international flags module (review)

* release_notes.md translator

* #2063 the flag files

* #2065 truncate match report if string is too long for database column (#2066)

* #2065 truncate match report if string is too long for database column

* #2065 rename AbstractTable.truncateString

* #2063 Guinea (#2068)

* #2063 download missing world details (#2070)

* #2063 download missing world details

* #2063 download missing world details

* #2063 download missing world details

* #2063 fix database error on matches reload

* #2069 (#2072)

* #2069 reduce space between team summary labels

* #2069 release_notes.md

* #1455 Initialize series table if no matches are played yet (#2073)

* #2069 reduce space between team summary labels

* #2069 release_notes.md

* #1455 initialize series table if no matches are played yet

* #1455 fix initial order of series table

* #1455 review

* #1455 review

* #1455 review

* #1455 review

* #1455 review

* #2074 update ratings when team spirit is changed (#2075)

* #1455 review

* #2074 update ratings when team spirit is changed

* #2076 sorting of youth table average column (#2077)

* #2078 ts forecast loads all trainer data (#2079)

* #2078 ts forecast loads all trainer data

* #2078 release_notes.md

* Create `stable` tag when `tag_stable` is created. (#2083) (#2085)

* Release/8 (#2084)

* Create `stable` tag when `tag_stable` is created.

* release stable HO8

* release stable HO8

---------

Co-authored-by: Sébastien Le Callonnec <sebastien@weblogism.com>

* Select suffix in extension block, as it then becomes immutable. (#2093)

* Fix issue with incorrect `-DEV` suffix in release.

The elvis operator returns the alternate branch if the condition is an empty string:

```groovy
groovy:000> "" ?: "pouet"
===> pouet

```

* Revert stable tag change to see if this is the root cause.

* Update version if GH action.

* Restore code.

* Re-create buid after manual delete of tags.

* Update release-dev.yml

Try using patched version to delete released version.

* Update release-dev.yml

Using the full SHA, as apparently this is required...

...although GH is even able to tell me which exact SHA to use!!  Also set the new option to true to trigger the deletion of non-draft.

* Update release-dev.yml

Latest version of GH action.

* Update release-dev.yml

* Update release-dev.yml

* #2094 youth scout comment sql error (#2095)

* #2094 youth scout comment sql error

* #2094 start 8.1 beta

* #2094 start 8.1 beta

* #2092 Fix skill tester rating predictions (#2098)

* #2092 Fix skill tester rating predictions

* #2092 typo

* #2097 Fix exception in youth player substitution (#2099)

* #2094 youth scout comment sql error

* #2094 start 8.1 beta

* #2094 start 8.1 beta

* #2092 typo

* #2097 Fix MatchLineupTeam.examineSubstitution

* #2097 build.gradle git reporting of v8.1

* #2097 Fix npe in MatchLineupTeam.initMinutesOfPlayersInSectors (#2101)

---------

Co-authored-by: Sébastien Le Callonnec <sebastien@weblogism.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reso: CHPP Resolution requires CHPP changes reso: week 16 the issue only appears during interseason (week 16) status: needs test might be fixed, needs test before closing
Projects
None yet
Development

No branches or pull requests

3 participants