Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Missing flags #2063

Closed
wsbrenk opened this issue May 5, 2024 · 7 comments
Closed

[BUG] Missing flags #2063

wsbrenk opened this issue May 5, 2024 · 7 comments
Assignees
Labels
status: needs test might be fixed, needs test before closing
Milestone

Comments

@wsbrenk
Copy link
Collaborator

wsbrenk commented May 5, 2024

Is it possible, that the flag collection in Beta 8 won't count the new flags?
...and the new countries (Guyana & Tahiti) are not included... at least flagwise....

@wsbrenk wsbrenk self-assigned this May 5, 2024
@wsbrenk wsbrenk added this to the 8.0 milestone May 5, 2024
wsbrenk added a commit to wsbrenk/HO that referenced this issue May 5, 2024
wsbrenk added a commit to wsbrenk/HO that referenced this issue May 5, 2024
@wsbrenk
Copy link
Collaborator Author

wsbrenk commented May 7, 2024

Neue Länder und Nationalmannschaften

Neben der Homegrown League begrüßen wir zur neuen Saison Guinea als neues Land. Wo wir gerade bei den neuen Ländern sind, es gibt einen Termin, zu dem alle Länder (auch die letzten neuen) im WM-System integriert werden. Das wird im Januar 2025 passieren. Der erste Wettbewerb, an dem alle Länder und ihre Nationalmannschaften teilnehmen können, ist die Kontinentalmeisterschaft, die im Januar beginnt.

wsbrenk added a commit that referenced this issue May 8, 2024
* #2063 add 5 new countries to international flags module

* #2063 add 5 new countries to international flags module (review)

* release_notes.md translator

* #2063 the flag files
@wsbrenk wsbrenk added the status: needs test might be fixed, needs test before closing label May 8, 2024
wsbrenk added a commit to wsbrenk/HO that referenced this issue May 15, 2024
@wsbrenk wsbrenk mentioned this issue May 15, 2024
2 tasks
wsbrenk added a commit that referenced this issue May 15, 2024
@Michelinho96
Copy link

I have a player from Belize, it would be nice if he also had his nationality flag

@wsbrenk
Copy link
Collaborator Author

wsbrenk commented May 19, 2024

@Michelinho96 if i see it right, the belize flag is part of HO since version 4.

@Michelinho96
Copy link

https://ibb.co/rH304mP

Unfortunately it didn't work for me in any version

@wsbrenk
Copy link
Collaborator Author

wsbrenk commented May 20, 2024

@Michelinho96 please try the following workaround:

If not already done, activate the International friendly module in File->Settings->Modules (and restart HO)
In the International friendly module you'll find an update button that hopefully will download the missing country informations:

image

@Michelinho96
Copy link

Perfect, it works, thank you!

wsbrenk added a commit to wsbrenk/HO that referenced this issue May 20, 2024
wsbrenk added a commit to wsbrenk/HO that referenced this issue May 20, 2024
wsbrenk added a commit to wsbrenk/HO that referenced this issue May 20, 2024
@wsbrenk
Copy link
Collaborator Author

wsbrenk commented May 20, 2024

mail from @Michelinho96 :

Hi,

I try the workaround:
activate the International friendly module in File->Settings->Modules (and restart HO)
In the International friendly module the update shows error:
java.sql.SQLException: Parameter not set
      at org.hsqldb.jdbc.JDBCUtil.sqlException(Unknown Source)
      at org.hsqldb.jdbc.JDBCUtil.sqlException(Unknown Source)
      at org.hsqldb.jdbc.JDBCUtil.sqlException(Unknown Source)
      at org.hsqldb.jdbc.JDBCPreparedStatement.checkParametersSet(Unknown Source)
      at org.hsqldb.jdbc.JDBCPreparedStatement.fetchResult(Unknown Source)
      at org.hsqldb.jdbc.JDBCPreparedStatement.executeUpdate(Unknown Source)
      at core.db.ConnectionManager.executePreparedUpdate(ConnectionManager.kt:105)
      at core.db.ConnectionManager.executePreparedUpdate(ConnectionManager.kt:96)
      at core.db.AbstractTable.executePreparedDelete(AbstractTable.java:413)
      at core.db.IfaMatchTable.deleteAllMatches(IfaMatchTable.java:77)
      at core.db.DBManager.deleteIFAMatches(DBManager.java:2059)
      at module.ifa.menu.RebuildDialog.actionPerformed(RebuildDialog.java:94)
      at java.desktop/javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1972)
      at java.desktop/javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2313)
      at java.desktop/javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:405)
      at java.desktop/javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:262)
      at java.desktop/javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:279)
      at java.desktop/java.awt.Component.processMouseEvent(Component.java:6626)
      at java.desktop/javax.swing.JComponent.processMouseEvent(JComponent.java:3389)
      at java.desktop/java.awt.Component.processEvent(Component.java:6391)
      at java.desktop/java.awt.Container.processEvent(Container.java:2266)
      at java.desktop/java.awt.Component.dispatchEventImpl(Component.java:5001)
      at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2324)
      at java.desktop/java.awt.Component.dispatchEvent(Component.java:4833)
      at java.desktop/java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4948)
      at java.desktop/java.awt.LightweightDispatcher.processMouseEvent(Container.java:4575)
      at java.desktop/java.awt.LightweightDispatcher.dispatchEvent(Container.java:4516)
      at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2310)
      at java.desktop/java.awt.Window.dispatchEventImpl(Window.java:2780)
      at java.desktop/java.awt.Component.dispatchEvent(Component.java:4833)
      at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:773)
      at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:722)
      at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:716)
      at java.base/java.security.AccessController.doPrivileged(AccessController.java:399)
      at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:86)
      at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:97)
      at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:746)
      at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:744)
      at java.base/java.security.AccessController.doPrivileged(AccessController.java:399)
      at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:86)
      at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:743)
      at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
      at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
      at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
      at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
      at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
      at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)
Caused by: org.hsqldb.HsqlException: Parameter not set
      at org.hsqldb.error.Error.error(Unknown Source)
      at org.hsqldb.error.Error.error(Unknown Source)
      ... 45 more

wsbrenk added a commit to wsbrenk/HO that referenced this issue May 20, 2024
wsbrenk added a commit that referenced this issue May 21, 2024
* #2063 download missing world details

* #2063 download missing world details

* #2063 download missing world details

* #2063 fix database error on matches reload
wsbrenk added a commit that referenced this issue May 21, 2024
* #1797 create beta (#2052)

* Fix build (#2054)

* #1797 create beta

* #1797 fix build

* #2055 fix slow opening of team analyzer panel (#2056)

* update release_notes.md

* #2055 remove unused info label

* #2055 remove unused info label (code analysis results)

* #2055 release_notes.md

* #2055 release_notes.md

* Use SwingWorker to properly fix hanging UI. (#2057)

* Update dependencies, in particular OkHttp to fix CVE. (#2058)

This fixes CVE-2023-3635, cf. https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-3635

* #2059 fix currency error in team analyzer's total salary column (#2060)

* #2063 add 5 new countries to international flags module (#2064)

* #2063 add 5 new countries to international flags module

* #2063 add 5 new countries to international flags module (review)

* release_notes.md translator

* #2063 the flag files

* #2065 truncate match report if string is too long for database column (#2066)

* #2065 truncate match report if string is too long for database column

* #2065 rename AbstractTable.truncateString

* #2063 Guinea (#2068)

* #2063 download missing world details (#2070)

* #2063 download missing world details

* #2063 download missing world details

* #2063 download missing world details

* #2063 fix database error on matches reload

---------

Co-authored-by: Sébastien Le Callonnec <sebastien@weblogism.com>
@wsbrenk wsbrenk closed this as completed Jun 1, 2024
wsbrenk added a commit that referenced this issue Jun 6, 2024
* #1797 create beta (#2052)

* Fix build (#2054)

* #1797 create beta

* #1797 fix build

* #2055 fix slow opening of team analyzer panel (#2056)

* update release_notes.md

* #2055 remove unused info label

* #2055 remove unused info label (code analysis results)

* #2055 release_notes.md

* #2055 release_notes.md

* Use SwingWorker to properly fix hanging UI. (#2057)

* Update dependencies, in particular OkHttp to fix CVE. (#2058)

This fixes CVE-2023-3635, cf. https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-3635

* #2059 fix currency error in team analyzer's total salary column (#2060)

* #2063 add 5 new countries to international flags module (#2064)

* #2063 add 5 new countries to international flags module

* #2063 add 5 new countries to international flags module (review)

* release_notes.md translator

* #2063 the flag files

* #2065 truncate match report if string is too long for database column (#2066)

* #2065 truncate match report if string is too long for database column

* #2065 rename AbstractTable.truncateString

* #2063 Guinea (#2068)

* #2063 download missing world details (#2070)

* #2063 download missing world details

* #2063 download missing world details

* #2063 download missing world details

* #2063 fix database error on matches reload

* #2069 (#2072)

* #2069 reduce space between team summary labels

* #2069 release_notes.md

* #1455 Initialize series table if no matches are played yet (#2073)

* #2069 reduce space between team summary labels

* #2069 release_notes.md

* #1455 initialize series table if no matches are played yet

* #1455 fix initial order of series table

* #1455 review

* #1455 review

* #1455 review

* #1455 review

* #1455 review

* #2074 update ratings when team spirit is changed (#2075)

* #1455 review

* #2074 update ratings when team spirit is changed

* #2076 sorting of youth table average column (#2077)

* #2078 ts forecast loads all trainer data (#2079)

* #2078 ts forecast loads all trainer data

* #2078 release_notes.md

---------

Co-authored-by: Sébastien Le Callonnec <sebastien@weblogism.com>
wsbrenk added a commit that referenced this issue Jun 23, 2024
* #1797 create beta (#2052)

* Fix build (#2054)

* #1797 create beta

* #1797 fix build

* #2055 fix slow opening of team analyzer panel (#2056)

* update release_notes.md

* #2055 remove unused info label

* #2055 remove unused info label (code analysis results)

* #2055 release_notes.md

* #2055 release_notes.md

* Use SwingWorker to properly fix hanging UI. (#2057)

* Update dependencies, in particular OkHttp to fix CVE. (#2058)

This fixes CVE-2023-3635, cf. https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-3635

* #2059 fix currency error in team analyzer's total salary column (#2060)

* #2063 add 5 new countries to international flags module (#2064)

* #2063 add 5 new countries to international flags module

* #2063 add 5 new countries to international flags module (review)

* release_notes.md translator

* #2063 the flag files

* #2065 truncate match report if string is too long for database column (#2066)

* #2065 truncate match report if string is too long for database column

* #2065 rename AbstractTable.truncateString

* #2063 Guinea (#2068)

* #2063 download missing world details (#2070)

* #2063 download missing world details

* #2063 download missing world details

* #2063 download missing world details

* #2063 fix database error on matches reload

* #2069 (#2072)

* #2069 reduce space between team summary labels

* #2069 release_notes.md

* #1455 Initialize series table if no matches are played yet (#2073)

* #2069 reduce space between team summary labels

* #2069 release_notes.md

* #1455 initialize series table if no matches are played yet

* #1455 fix initial order of series table

* #1455 review

* #1455 review

* #1455 review

* #1455 review

* #1455 review

* #2074 update ratings when team spirit is changed (#2075)

* #1455 review

* #2074 update ratings when team spirit is changed

* #2076 sorting of youth table average column (#2077)

* #2078 ts forecast loads all trainer data (#2079)

* #2078 ts forecast loads all trainer data

* #2078 release_notes.md

* Create `stable` tag when `tag_stable` is created. (#2083) (#2085)

* Release/8 (#2084)

* Create `stable` tag when `tag_stable` is created.

* release stable HO8

* release stable HO8

---------

Co-authored-by: Sébastien Le Callonnec <sebastien@weblogism.com>

---------

Co-authored-by: Sébastien Le Callonnec <sebastien@weblogism.com>
wsbrenk added a commit that referenced this issue Jun 23, 2024
* #1797 create beta (#2052)

* Fix build (#2054)

* #1797 create beta

* #1797 fix build

* #2055 fix slow opening of team analyzer panel (#2056)

* update release_notes.md

* #2055 remove unused info label

* #2055 remove unused info label (code analysis results)

* #2055 release_notes.md

* #2055 release_notes.md

* Use SwingWorker to properly fix hanging UI. (#2057)

* Update dependencies, in particular OkHttp to fix CVE. (#2058)

This fixes CVE-2023-3635, cf. https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-3635

* #2059 fix currency error in team analyzer's total salary column (#2060)

* #2063 add 5 new countries to international flags module (#2064)

* #2063 add 5 new countries to international flags module

* #2063 add 5 new countries to international flags module (review)

* release_notes.md translator

* #2063 the flag files

* #2065 truncate match report if string is too long for database column (#2066)

* #2065 truncate match report if string is too long for database column

* #2065 rename AbstractTable.truncateString

* #2063 Guinea (#2068)

* #2063 download missing world details (#2070)

* #2063 download missing world details

* #2063 download missing world details

* #2063 download missing world details

* #2063 fix database error on matches reload

* #2069 (#2072)

* #2069 reduce space between team summary labels

* #2069 release_notes.md

* #1455 Initialize series table if no matches are played yet (#2073)

* #2069 reduce space between team summary labels

* #2069 release_notes.md

* #1455 initialize series table if no matches are played yet

* #1455 fix initial order of series table

* #1455 review

* #1455 review

* #1455 review

* #1455 review

* #1455 review

* #2074 update ratings when team spirit is changed (#2075)

* #1455 review

* #2074 update ratings when team spirit is changed

* #2076 sorting of youth table average column (#2077)

* #2078 ts forecast loads all trainer data (#2079)

* #2078 ts forecast loads all trainer data

* #2078 release_notes.md

* Create `stable` tag when `tag_stable` is created. (#2083) (#2085)

* Release/8 (#2084)

* Create `stable` tag when `tag_stable` is created.

* release stable HO8

* release stable HO8

---------

Co-authored-by: Sébastien Le Callonnec <sebastien@weblogism.com>

* release stable HO8

* release stable HO8

---------

Co-authored-by: Sébastien Le Callonnec <sebastien@weblogism.com>
wsbrenk added a commit that referenced this issue Jul 4, 2024
* #1797 create beta (#2052)

* Fix build (#2054)

* #1797 create beta

* #1797 fix build

* #2055 fix slow opening of team analyzer panel (#2056)

* update release_notes.md

* #2055 remove unused info label

* #2055 remove unused info label (code analysis results)

* #2055 release_notes.md

* #2055 release_notes.md

* Use SwingWorker to properly fix hanging UI. (#2057)

* Update dependencies, in particular OkHttp to fix CVE. (#2058)

This fixes CVE-2023-3635, cf. https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-3635

* #2059 fix currency error in team analyzer's total salary column (#2060)

* #2063 add 5 new countries to international flags module (#2064)

* #2063 add 5 new countries to international flags module

* #2063 add 5 new countries to international flags module (review)

* release_notes.md translator

* #2063 the flag files

* #2065 truncate match report if string is too long for database column (#2066)

* #2065 truncate match report if string is too long for database column

* #2065 rename AbstractTable.truncateString

* #2063 Guinea (#2068)

* #2063 download missing world details (#2070)

* #2063 download missing world details

* #2063 download missing world details

* #2063 download missing world details

* #2063 fix database error on matches reload

* #2069 (#2072)

* #2069 reduce space between team summary labels

* #2069 release_notes.md

* #1455 Initialize series table if no matches are played yet (#2073)

* #2069 reduce space between team summary labels

* #2069 release_notes.md

* #1455 initialize series table if no matches are played yet

* #1455 fix initial order of series table

* #1455 review

* #1455 review

* #1455 review

* #1455 review

* #1455 review

* #2074 update ratings when team spirit is changed (#2075)

* #1455 review

* #2074 update ratings when team spirit is changed

* #2076 sorting of youth table average column (#2077)

* #2078 ts forecast loads all trainer data (#2079)

* #2078 ts forecast loads all trainer data

* #2078 release_notes.md

* Create `stable` tag when `tag_stable` is created. (#2083) (#2085)

* Release/8 (#2084)

* Create `stable` tag when `tag_stable` is created.

* release stable HO8

* release stable HO8

---------

Co-authored-by: Sébastien Le Callonnec <sebastien@weblogism.com>

* #2094 youth scout comment column length

---------

Co-authored-by: Sébastien Le Callonnec <sebastien@weblogism.com>
wsbrenk added a commit that referenced this issue Jul 6, 2024
* #1797 create beta (#2052)

* Fix build (#2054)

* #1797 create beta

* #1797 fix build

* #2055 fix slow opening of team analyzer panel (#2056)

* update release_notes.md

* #2055 remove unused info label

* #2055 remove unused info label (code analysis results)

* #2055 release_notes.md

* #2055 release_notes.md

* Use SwingWorker to properly fix hanging UI. (#2057)

* Update dependencies, in particular OkHttp to fix CVE. (#2058)

This fixes CVE-2023-3635, cf. https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-3635

* #2059 fix currency error in team analyzer's total salary column (#2060)

* #2063 add 5 new countries to international flags module (#2064)

* #2063 add 5 new countries to international flags module

* #2063 add 5 new countries to international flags module (review)

* release_notes.md translator

* #2063 the flag files

* #2065 truncate match report if string is too long for database column (#2066)

* #2065 truncate match report if string is too long for database column

* #2065 rename AbstractTable.truncateString

* #2063 Guinea (#2068)

* #2063 download missing world details (#2070)

* #2063 download missing world details

* #2063 download missing world details

* #2063 download missing world details

* #2063 fix database error on matches reload

* #2069 (#2072)

* #2069 reduce space between team summary labels

* #2069 release_notes.md

* #1455 Initialize series table if no matches are played yet (#2073)

* #2069 reduce space between team summary labels

* #2069 release_notes.md

* #1455 initialize series table if no matches are played yet

* #1455 fix initial order of series table

* #1455 review

* #1455 review

* #1455 review

* #1455 review

* #1455 review

* #2074 update ratings when team spirit is changed (#2075)

* #1455 review

* #2074 update ratings when team spirit is changed

* #2076 sorting of youth table average column (#2077)

* #2078 ts forecast loads all trainer data (#2079)

* #2078 ts forecast loads all trainer data

* #2078 release_notes.md

* Create `stable` tag when `tag_stable` is created. (#2083) (#2085)

* Release/8 (#2084)

* Create `stable` tag when `tag_stable` is created.

* release stable HO8

* release stable HO8

---------

Co-authored-by: Sébastien Le Callonnec <sebastien@weblogism.com>

* Select suffix in extension block, as it then becomes immutable. (#2093)

* Fix issue with incorrect `-DEV` suffix in release.

The elvis operator returns the alternate branch if the condition is an empty string:

```groovy
groovy:000> "" ?: "pouet"
===> pouet

```

* Revert stable tag change to see if this is the root cause.

* Update version if GH action.

* Restore code.

* Re-create buid after manual delete of tags.

* Update release-dev.yml

Try using patched version to delete released version.

* Update release-dev.yml

Using the full SHA, as apparently this is required...

...although GH is even able to tell me which exact SHA to use!!  Also set the new option to true to trigger the deletion of non-draft.

* Update release-dev.yml

Latest version of GH action.

* Update release-dev.yml

* Update release-dev.yml

* #2094 youth scout comment sql error (#2095)

* #2094 youth scout comment sql error

* #2094 start 8.1 beta

* #2094 start 8.1 beta

* #2092 Fix skill tester rating predictions (#2098)

* #2092 Fix skill tester rating predictions

* #2092 typo

* #2097 Fix exception in youth player substitution (#2099)

* #2094 youth scout comment sql error

* #2094 start 8.1 beta

* #2094 start 8.1 beta

* #2092 typo

* #2097 Fix MatchLineupTeam.examineSubstitution

* #2097 build.gradle git reporting of v8.1

* #2097 Fix npe in MatchLineupTeam.initMinutesOfPlayersInSectors (#2101)

---------

Co-authored-by: Sébastien Le Callonnec <sebastien@weblogism.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs test might be fixed, needs test before closing
Projects
None yet
Development

No branches or pull requests

2 participants