Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling testmode #2

Closed
petervanackooij opened this issue May 4, 2019 · 2 comments
Closed

Enabling testmode #2

petervanackooij opened this issue May 4, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@petervanackooij
Copy link

Hi,

I figured out that setting the api to testmode can be done by adding the $clientUrl to the ClientConfig constructor. Works fine, but as a user of the package I really don't care about the urls, I just want to enable or disable testmode.

I see two solutions to this enhancement:

1: You're doing such a great job putting everything in constants, let's put these url's in constants as well, so I can grab them when needed.

2: My favourite and it extends solution 1: Change the constructor in ClientConfig and replace the $clientUrl parameter with $testMode. The $testMode boolean will decide witch of the two urls to use.

@JeroenVanLeusden JeroenVanLeusden self-assigned this May 6, 2019
@JeroenVanLeusden JeroenVanLeusden added the enhancement New feature or request label May 6, 2019
@JeroenVanLeusden
Copy link

I'll add it to the backlog, bol.com will determine when this will be implemented. I can't tell you when exactly.

@JeroenVanLeusden
Copy link

@petervanackooij It's implemented in cda1139.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants