Skip to content
This repository has been archived by the owner on Sep 20, 2021. It is now read-only.

Add hoa\devtools to suggest package in composer.json #30

Open
ghost opened this issue Jul 6, 2018 · 6 comments · May be fixed by #31
Open

Add hoa\devtools to suggest package in composer.json #30

ghost opened this issue Jul 6, 2018 · 6 comments · May be fixed by #31

Comments

@ghost
Copy link

ghost commented Jul 6, 2018

As of #29 mentioned, the usage of flex entity will break some static analyzer. It might be a good idea to add hoa\devtools to suggest package.

@Hywan
Copy link
Member

Hywan commented Aug 15, 2018

That's a good idea.

Thanks! I think we can add it to hoaproject/Central#75. Should we integrate it as part of our roadmap @vonglasow & @shulard?

@shulard
Copy link

shulard commented Aug 16, 2018

Seems a good idea to reference the hoa/devtools package in suggest but we need to find the right sentence to use to describe the suggest meaning 😄.

@Hywan
Copy link
Member

Hywan commented Aug 17, 2018

To polish the integration of Hoa inside your IDE, consider installing hoa/devtools.

I don't know if it describes well the situation though.

@shulard
Copy link

shulard commented Aug 20, 2018

When installing hoa/devtools, does it fix the flex entity "problem" with static analyzer ?

@ghost
Copy link
Author

ghost commented Aug 20, 2018

@shulard Yes. At least in phpStorm.

@shulard shulard linked a pull request Aug 20, 2018 that will close this issue
shulard added a commit to shulard/Consistency that referenced this issue Aug 20, 2018
As of hoaproject#29 mentioned, the usage of flex entity will break some static analyzer. Adding `hoa/devtools` as a dependency fix the problem at least in PHPStorm.

Must fix hoaproject#30.
@shulard
Copy link

shulard commented Aug 20, 2018

Ok so the sentence LGTM, I've created a PR : #31.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging a pull request may close this issue.

2 participants