This repository has been archived by the owner on Sep 20, 2021. It is now read-only.
Mock: Add ability to mock constant #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hywan
force-pushed
the
constant_mocker
branch
from
5c9279d
to
d27e8bc
Compare
Hywan
force-pushed
the
constant_mocker
branch
from
d27e8bc
to
f830c5e
Compare
|
Related to atoum/atoum#511. |
| $constantMocker = new Test\Mocker\Constant($this->getPhpMocker()); | ||
| $this->getAssertionManager()->setPropertyHandler( | ||
| 'constant', | ||
| function () use ($constantMocker) { |
There was a problem hiding this comment.
It's not necessary. PHP does it for us.
|
seems good ;) would have been as easy to do it directly in atoum :p |
|
@jubianchi Yup, that's really easy to integrate inside atoum and it's a great feature! |
|
@jubianchi I can do that today. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It works \o/.
Please, can I have a peer review from @jubianchi?
The goal is to get soon to be able to merge hoaproject/Console#58. Then, I will propose it into atoum.