Empty bookmark #225 #227
Closed
Empty bookmark #225 #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
preventing the creation of empty bookmarks in the UI and the rest api updated gitignore
MohamedBassem
requested changes
Jun 16, 2024
Comment on lines
+207
to
+213
| } else if (input.type === "text") { | ||
| if (!input.text) { | ||
| throw new TRPCError({ | ||
| message: "Creating empty bookmarks is not allowed", | ||
| code: "BAD_REQUEST", | ||
| }); | ||
| } |
There was a problem hiding this comment.
We don't typically do input validation on the code. This kind of validation should live in the zod schema. However, I don't really think this is something worth enforcing on the server side anyways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preventing the creation of empty bookmarks in the UI and the rest api
updated gitignore