Not Displaying in IE 11 - Even the demo page

[itssampath]

Simple-keyboard version
We tried to use Simple keyboard in Angular 8. Working fine in FireFox.

Describe the bug
Not Displayed in IE 11. I could see script error.
Root cause is - In index.js
(l = b.classList).add.apply(l, _toConsumableArray(t.getButtonThemeClasses(e)))
throws "Argument not optional"

Screenshots
Try opening demo page in IE 11. No Keyboard is displayed.

[hodgef]

Hello @itssampath,

The simple-keyboard demos are coded in ES6+, thus not supported in Internet Explorer.

For example:

let keyboard = new Keyboard({
  onChange: input => onChange(input),
  onKeyPress: button => onKeyPress(button)
});

Will not run in IE due to the arrow functions.

In a previous demo I had the following message shown:

I will look into adding it back just as a heads up to users.

Regards,
Francisco Hodge

[nicoabie]

I completely support the decision of the author @hodgef to not support IE11.
Unfortunately there exist cases where people are hired to make it work in IE11 because some institutions like banks still work with such browsers.

The issue here described is because IE11 does not support certain operations with multiple arguments in classList see here

In order to fix this a classList polyfill is required.

I suggest this one which has the latest version of https://github.com/eligrey/classList.js. Be aware that most documentation will tell you to run npm i --save classlist.js but that one does NOT resolve this issue because it is outdated.

I leave this comment in case anyone has to make it work in IE11

[hodgef]

Thanks for sharing this fix @nicoabie ! Much appreciated

[hodgef]

Update: simple-keyboard v3+ now supports IE11 😄

Compatibility list: https://github.com/hodgef/simple-keyboard#-compatibility

Please note : The demos (meant for devs) do not support IE, but the end product (the library) does.

Regards,
Francisco Hodge