Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the audit findings #21

Merged
merged 2 commits into from
Jul 27, 2021
Merged

Fix the audit findings #21

merged 2 commits into from
Jul 27, 2021

Conversation

alxkzmn
Copy link
Contributor

@alxkzmn alxkzmn commented Jul 27, 2021 •
edited by antoncoding
Loading

Fixes

  • PEV001: Use safeTransfer instead of transfer
  • PEV002: Use .sub instead of - for time calculation
  • PEV003: Update documentations to match the code.

@alxkzmn alxkzmn requested a review from antoncoding July 27, 2021 10:29
antoncoding
antoncoding approved these changes Jul 27, 2021
View reviewed changes
Copy link
Collaborator

@antoncoding antoncoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use .sub() for L104 as well:

totalTime = _expiry - block.timestamp;

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.773% when pulling ea75338 on audit-findings-fix into e905795 on master.

@antoncoding antoncoding merged commit a939079 into master Jul 27, 2021
@antoncoding antoncoding deleted the audit-findings-fix branch July 27, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoncoding antoncoding antoncoding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alxkzmn @coveralls @antoncoding