Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix refactor_reportingtools_table.rb crash whenrun with non-ENS feature IDs and feature_type not 'gene' #210

Merged
merged 9 commits into from
Feb 3, 2023

Conversation

fischer-hub
Copy link
Collaborator

When we know we have valid ENS IDs we can use the features ENS stable ID prefix (ENSG, ENST etc.) to scan for the gene ID in the HTML report from reporting tools. This fails with arbitrary IDs if the feature the GTF was filtered for is not also the gene ID because we then have a gene ID from the reporting tools report and an exon / transcript ID from the filtered GTF that we cant map to each other.

  • added valid ENS ID check
  • added additional mapping from gene ID to feature ID from the GTF file to later map to the feature name, gene biotype and features position in case non-ENS IDs were detected and standard mapping fails (feature type is not 'gene')

closes #204

@hoelzer
Copy link
Contributor

hoelzer commented Feb 3, 2023

@fischer-hub looks good now, great! I now get the correct PCAs on this branch (do we still needed then PR #209 ?)

Two things:

  1. do you know why in the ReportingTools output the images are not shown? E.g.:

Screenshot from 2023-02-03 08-47-33

  1. Do you know why this folder _vs_SBY is generated:
(base) ➜  rnaflow-test-data-david ls results-SBY92ref-CBS14_P2_vs_SBY92_P3-debugging/07-DifferentialExpression/DESeq2/                                                                  
CBS14_P2_vs_SBY92_P3  data  deseq2.Rout  plots  _vs_SBY

The content is just:

results-SBY92ref-CBS14_P2_vs_SBY92_P3-debugging/07-DifferentialExpression/DESeq2/_vs_SBY
└── downstream_analysis
    └── piano

2 directories, 0 files

so maybe this is generated during the piano function?

@fischer-hub
Copy link
Collaborator Author

@hoelzer No, I think I'll delete #209

1. do you know why in the ReportingTools output the images are not shown? E.g.:

I think you are looking at the raw Reportingtools report no? The refactored one has 'extended' as a suffix. The extended report for me shows the images.
image

2. Do you know why this folder `_vs_SBY` is generated:

Nice catch, yes there was a broken regex in the Webgestalt and Piano processes that didn't match the right comparison names :D I added a fix in the last commit.

@hoelzer
Copy link
Contributor

hoelzer commented Feb 3, 2023

Yes then let's simply delete PR #209 !

Ah, I thought the "normal" report also had these little thumbnails - okay anyway you're right!

I tested the branch again and the folder is gone now!

Looks all good from my side. I would do a merge and little release w/ these fixes for non-model input annotations. Thx!

@hoelzer hoelzer merged commit 630e02e into master Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReportingTools does not finish the HTML plot
2 participants