Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pre-commit action against merge-base #33

Merged
merged 15 commits into from
Feb 13, 2022

Conversation

cbachhuber
Copy link
Contributor

@cbachhuber cbachhuber commented Feb 12, 2022

@cbachhuber
Copy link
Contributor Author

Caching works just fine with the action! In the first passing run, pre-commit required 55s, in the run after that only 20s 🎉

@cbachhuber
Copy link
Contributor Author

cbachhuber commented Feb 12, 2022

@hofbi let's have pre-commit integration even nicer, as e.g. at CLIUtils/CLI11#689. Can you authorize github at https://pre-commit.ci/ and add pre-commit ci to this repo?

@hofbi
Copy link
Owner

hofbi commented Feb 13, 2022

Ok, done.

To trigger the CI you could also update https://github.com/hofbi/telecarla/pull/33/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fR15 to v2 and add the pre-commit.ci badge to the readme.

@cbachhuber
Copy link
Contributor Author

To trigger the CI you could also update https://github.com/hofbi/telecarla/pull/33/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fR15[](https://github.com/cbachhuber) to v2 and add the pre-commit.ci badge to the readme.

Badge done, what exactly do you mean with the v2 part?

@hofbi
Copy link
Owner

hofbi commented Feb 13, 2022

Is this one ready?

@cbachhuber
Copy link
Contributor Author

cbachhuber commented Feb 13, 2022

Yes, except the v2 thing that I didn't understand.Is that resolved?

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@cbachhuber cbachhuber marked this pull request as ready for review February 13, 2022 16:47
@hofbi hofbi merged commit a9b0b2e into hofbi:master Feb 13, 2022
@cbachhuber cbachhuber deleted the speed-up-pre-commit-in-ci branch February 13, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants