mvDrawRect: Removed the default for corner_colors

[v-ein]

so that it doesn't break the old color arguments

---

name: Pull Request
about: Create a pull request to help us improve
title: mvDrawRect: Removed the default for corner_colors so that it doesn't break the old color arguments
assignees: @hoffstadt

---

Description:
The commit that added corner_colors to draw_rectangle also set it by default to all-white colors. Unfortunately this breaks old arguments named color_yyy_zzz, since the default for corner_colors overrides whatever is specified in color_yyy_zzz.

Concerning Areas:
I'm not sure how much of a problem it is to have a default of None.

If you'd prefer to keep the default in dearpygui.py, there's another way to resolve this issue. We can parse corner_colors before color_yyy_zzz. This would involve changes in mvDrawings.cpp rather than dearpygui.py. Please let me know if that's the way to go.

[SamuMazzi]

Why didn't you change also the default parameter in mvAppItem.cpp?

[v-ein]

Why didn't you change also the default parameter in mvAppItem.cpp?

Good point. Not that it affected anything (it seems to be purely for doc), but yeah, it might be a good idead to change it, too. Well, in fact, if you don't specify a value for corner_colors, a list of all 255's describes the default pretty well 😂.

[SamuMazzi]

Yeah it doesn't break anything, but that's the "source file" for the documentation and all the .py files so if you don't change it, next time someone will build it it's gonna set the old value again (as far as I know at least)