Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prismic #3

Merged
merged 2 commits into from
Mar 1, 2016
Merged

Update prismic #3

merged 2 commits into from
Mar 1, 2016

Conversation

richardstevens
Copy link
Contributor

What does this PR do? (please provide any background)

Updating metalsmith-prismic to clear old hardcoded dependancy and fix for new version of prismic api

How can this be tested?

locally npm link this repo to a ssg-sites repo, then run as normal


Reviewers

Review 1

  • 👍

Review 2 *

  • 👍

Review 3 (optional)

  • 👍

By adding a +1 you are confirming you have...

  • Witnessed the work behaving as expected (this could be on the author's machine or screencast).
  • Checked for coding anti-patterns.
  • Checked for appropriate test coverage.
  • Checked all the tests are passing.

* for HX this review must be completed by an SE, SA or Project Guru

@elliottcrush
Copy link
Contributor

Great stuff, nice trimming of dependencies as well. Have tried this out locally with static-site-generator-sites on the testing branch and it works well. Glad that we've got more support for different data stores inside prismic. 👍

richardstevens pushed a commit that referenced this pull request Mar 1, 2016
@richardstevens richardstevens merged commit 89d1d2b into master Mar 1, 2016
@richardstevens richardstevens deleted the update_prismic branch March 26, 2016 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants