Adding option for different endpoints for content #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if ( doc.isBroken ) return ''; | ||
| return '/' + doc.uid; | ||
| } | ||
| }, opts.dataSource.token ); |
There was a problem hiding this comment.
nice, thanks for adding this. Makes everything a bit more secure.
|
1️⃣ |
|
All good after readme is updated with documentation on what config now needs to be used for any project consuming this. Great stuff! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? (please provide any background)
We needed to allow for some more data sources instead of just prismic, in this case i have added an option called hxseo (To use our existing hxseo database) but also the ability to pass in a dataSource function for you to create your own if needs be.
What tests does this PR have?
The normal CI linting currently
How can this be tested?
You can download this locally and npm link to the static-site-generator-sites repo to test against existing setup.
Reviewers
Review 1
Review 2 *
Review 3 (optional)
By adding a +1 you are confirming you have...
* for HX this review must be completed by an SE, SA or Project Guru