Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testcases for EELS-bugs #140

Merged
merged 9 commits into from
Apr 12, 2024
Merged

Testcases for EELS-bugs #140

merged 9 commits into from
Apr 12, 2024

Conversation

@holiman holiman changed the title More examples Testcases for EELS-bugs Apr 8, 2024
@holiman
Copy link
Owner Author

holiman commented Apr 12, 2024

@gurukamath I pushed a couple of changes to the last eels-test. Unfortunately, it seems that the statetest branch is deleted from the repository, making it a lot more difficult for me to verify that it still triggers the bug.
Previously, I just use my docker image on that branch, and reverted the fix-commit. But by docker image is shallow, and I can not git fetch --unshallow since the branch is gone.

Anyway: would it be possible for you to verify that tstore_test-2.json fails on the bad version?

@gurukamath
Copy link
Contributor

@gurukamath I pushed a couple of changes to the last eels-test. Unfortunately, it seems that the statetest branch is deleted from the repository, making it a lot more difficult for me to verify that it still triggers the bug. Previously, I just use my docker image on that branch, and reverted the fix-commit. But by docker image is shallow, and I can not git fetch --unshallow since the branch is gone.

Anyway: would it be possible for you to verify that tstore_test-2.json fails on the bad version?

Yes. The latest version of tstore_test-2.json does in fact fail with the buggy version of eels and passes with the fixed version.

@holiman holiman merged commit 4627df2 into master Apr 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants