Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add minimum scopes for access token to website #1

Closed
hollodotme opened this issue Dec 3, 2018 · 1 comment
Closed

Add minimum scopes for access token to website #1

hollodotme opened this issue Dec 3, 2018 · 1 comment
Assignees
@hollodotme
Labels
enhancement New feature or request
Milestone
v1.0.1

Comments

@hollodotme
Copy link
Owner

hollodotme commented Dec 3, 2018 •
edited
Loading

Expected Behavior

Analysis works when using an access token with minimum scopes.
If minimum scopes are not set a proper validation error is displayed.

Actual Behavior

Minimum scopes are not mentioned on the website and not validated properly when receiving the API result.

Steps to Reproduce the Problem

  1. Create a new personal access token
  2. Do not select any scope
  3. Use the website

Specifications

  • Package version: 1.0.0

Further comments

@mablae tested public organizations with scope repo:public_repo.

I guess for private repositories read:org is additionally needed.
@hollodotme hollodotme added the enhancement New feature or request label Dec 3, 2018
@hollodotme hollodotme added this to the v1.0.1 milestone Dec 3, 2018
@hollodotme hollodotme self-assigned this Dec 3, 2018
@hollodotme
Copy link
Owner Author

OK, for private repositories the complete repo scope must be selected.

hollodotme added a commit that referenced this issue Dec 3, 2018
@hollodotme
Add documentation about access token scopes, #1
fc40e18
hollodotme added a commit that referenced this issue Dec 3, 2018
@hollodotme
Check minimum access token scopes from response headers, #1
1e46182
hollodotme added a commit that referenced this issue Dec 3, 2018
@hollodotme
Improve error output on exceptions, #1
93ea82c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hollodotme hollodotme

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.0.1
Development

No branches or pull requests
1 participant
@hollodotme