You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've figured out the reason for the argument order bug:
The problem is with the graph generation. See GraphImpl.java line 155 (or all of fromCommand). Basically, it first generates a ConversionNode for the "AB together" syntax, and in doing so adds the argument "A" to the command's children (syntaxNode.nextMap). The executor for "A"'s ConversionNode is set to null, because the converter doesn't know about the "A only" syntax (and so it is doing the right thing to say that "cmd a" would not have an executor).
The issue is that because "A" is already added to the command's children, the graph generator skips it and does not add the newly found executor.
I'm not sure how to fix this yet but I'll keep trying. I think it's going to have to be something horrible, or just rewrite parts of ConversionNode, because currently it's a record and everything is final.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created from Minestom#1893