Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rdiscount -> kramdown #43

Closed
katyhuff opened this issue Feb 4, 2016 · 10 comments
Closed

rdiscount -> kramdown #43

katyhuff opened this issue Feb 4, 2016 · 10 comments

Comments

@katyhuff
Copy link

katyhuff commented Feb 4, 2016

First, thanks for left. I like and use and rely on it.

Now... I see that github is no longer going to support rdiscount in jekyll pages (you're aware of this too, I see: github/pages-gem#179). That's cool. I'm down with that. Trouble is, moving from rdiscount to kramdown in left has mysteriously screwed up my index page rendering. This could totally be my flawed use of left. I hope you'll let me know if that's the case. Here's the source.

I had my index page looking like:
screen shot 2016-02-03 at 8 20 24 pm

I made (more or less) the following changes to my config.yml file:

- markdown: rdiscount
- rdiscount:
-     extensions: [smart]
+ markdown: kramdown
+ kramdown:
+    input: GHM
+    hard_wrap: false

Now, it renders terribly.

screen shot 2016-02-03 at 8 19 52 pm

Any idea what I should do on that front?

@holman
Copy link
Owner

holman commented Feb 4, 2016

This brings up a good point; I went and updated Left to use Jekyll 3 in #44. That might be helpful for you. I'm also going to take a peek at your stuff next- brb!

@holman
Copy link
Owner

holman commented Feb 4, 2016

Lookin' sharp to me!

screen shot 2016-02-03 at 8 54 42 pm

...did you restart your server? :) Are there any errors that the server is spitting out?

@katyhuff
Copy link
Author

katyhuff commented Feb 4, 2016

I changed it back to rdiscount since it's a live site and I didn't want it
to be ugly all night. (
https://github.com/thehackerwithin/berkeley/blob/gh-pages/_config.yml).
If you make just the one change, you'll see it fail:

- markdown: rdiscount
+ markdown: kramdown

I'll push an ugly version to katyhuff.github.io/berkeley/

On Wed, Feb 3, 2016 at 8:55 PM, Zach Holman notifications@github.com
wrote:

Lookin' sharp to me!

[image: screen shot 2016-02-03 at 8 54 42 pm]
https://cloud.githubusercontent.com/assets/2723/12806171/637b2a50-cab8-11e5-99fe-331ade0b7414.png

...did you restart your server? :) Are there any errors that the server is
spitting out?


Reply to this email directly or view it on GitHub
#43 (comment).

http://katyhuff.github.com

@katyhuff
Copy link
Author

katyhuff commented Feb 4, 2016

alright katyhuff.github.io/berkeley/ is kramdown-ified now.

@holman
Copy link
Owner

holman commented Feb 4, 2016

So I can reproduce it and it's really strange. Going to keep looking at it because I'm pretty sure it's something obvious that I'm missing.

@holman
Copy link
Owner

holman commented Feb 4, 2016

Cool, figured it out:

diff --git a/_config.yml b/_config.yml
index adad3c4..7cfd329 100644
--- a/_config.yml
+++ b/_config.yml
@@ -4,6 +4,7 @@ markdown: rdiscount
 kramdown:
   input: GFM
   hard_wrap: false
+  parse_block_html: true
 github: thehackerwithin
 url: http://thehackerwithin.github.com/berkeley 
 name: Hacker Within
@@ -12,4 +13,3 @@ description: An initial blog and site for THW at UCB
 twitter: hackerwithin
 gravatar_url: http://www.gravatar.com/avatar/0203c034a145af6cc2576d56cdb4cf73
 disqus_username: hackerwithinadmin

I noticed that it didn't parse the Markdown when wrapped in an HTML tag. According to the kramdown docs, parse_block_html is disabled by default, so it was seeing the HTML tag and bailing. Guess those Markdown renderers aren't quite the same.

Let me know if this works for you!

@katyhuff
Copy link
Author

katyhuff commented Feb 4, 2016

Heck yes!!
Thanks @holman !

@katyhuff katyhuff closed this as completed Feb 4, 2016
katyhuff added a commit to thehackerwithin/template that referenced this issue Feb 24, 2016
katyhuff added a commit to thehackerwithin/davis that referenced this issue Feb 25, 2016
katyhuff added a commit to thehackerwithin/swinburne that referenced this issue Feb 25, 2016
@katyhuff
Copy link
Author

katyhuff commented May 3, 2016

Hi there @holman . I think we have to reopen this. It looks like they finished the transition to kramdown yesterday. I assume that change caused things to look ugly again:

for me: https://thehackerwithin.github.com/berkeley/upcoming.html
and for you: https://zachholman.com/left/

I tried a couple of changes to my config file such as:

 markdown: kramdown
+highlighter: rouge
 kramdown:
   input: GFM
   hard_wrap: false
   parse_block_html: true
+  parse_span_html: true
+  auto_ids: true
+  smart_quotes: lsquo,rsquo,ldquo,rdquo
+  enable_coderay: false
+  syntax_highlighter: rouge

none of these additions helped.

@holman
Copy link
Owner

holman commented May 3, 2016

Yours is fixed if you hit the http version instead of https; you have insecure content warnings so your browser isn't rendering the styles.

I'm fixing zachholman.com/left as soon as anything remotely works on github.

@katyhuff
Copy link
Author

katyhuff commented May 3, 2016

oh geez. bitmoji

Right you are. Sorry for bugging you about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants