This repository has been archived by the owner on Nov 21, 2018. It is now read-only.
append hdk-rust as a dep for generated rust zomes #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedavidmeister
approved these changes
Aug 29, 2018
lucksus
approved these changes
Aug 29, 2018
ddd-mtl
suggested changes
Aug 29, 2018
ddd-mtl
approved these changes
Aug 29, 2018
sphinxc0re
suggested changes
Aug 29, 2018
src/cli/scaffold/rust.rs
Outdated
| // @see https://github.com/holochain/holochain-cmd/issues/19 | ||
| let hdk_dep: &str = "hdk = { git = \"https://github.com/holochain/hdk-rust\" }"; | ||
|
|
||
| f.write_all(hdk_dep.as_bytes())?; |
There was a problem hiding this comment.
I would like to see the build configuration for wasm added as well. It needs to be built using this configuration:
[lib]
crate-type = ["cdylib"]There was a problem hiding this comment.
@lucksus Do you know more about this?
There was a problem hiding this comment.
so you do think we should be generating these with '--lib' for crates of the library type then?
There was a problem hiding this comment.
@sphinxc0re can we add a ticket and address in a separate PR?
There was a problem hiding this comment.
I really think this should be done right here 😅
There was a problem hiding this comment.
Ok so I have questions:
Will this crate-type property work if the crate is not of type lib? I am happy to add it, but I'd like to understand what it does
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #17
followup #19