This repository has been archived by the owner on Feb 3, 2023. It is now read-only.
consolidate env vars into one file #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphinxc0re
previously requested changes
Feb 12, 2019
|
@sphinxc0re made your change requests |
|
@ddd-mtl I know there was a change to the name of the env var you used in your PR, but I noticed while doing this that now it is the only one without an Re. |
zippy
approved these changes
Feb 12, 2019
lucksus
approved these changes
Feb 12, 2019
Connoropolous
dismissed
sphinxc0re’s stale review
changes were made (and Julian is asleep)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to this in the SoA tree
https://realtimeboard.com/app/board/o9J_kyiXmFs=/?moveToWidget=3074457346447871323
Creates a nice docs page like this
