update node clip pathing #96
Conversation
ahdinosaur
commented
Jun 11, 2015
ahdinosaur
commented
- change to work on Firefox (close Firefox does not support clip-path: circle() #50)
| fill: '#ECEFF1' | ||
| }), | ||
| }) : null /* React.createElement('rect', { |
There was a problem hiding this comment.
@simontegg i'm torn whether we should have a rectangular background behind a group avatar similar to the people avatar. in some ways it makes sense, as it emphasizes the 'group as square' symbol, but also is blocky and sometimes the arrows are behind the rectangle (which is a bug anyways for groups with square icons), so for now i just commented it out.
There was a problem hiding this comment.
I'm not sold that groups should be squares.
|
no longer does "don't clip for groups (close holodex/holodex#53)" @simontegg good to merge? |
|
I'm still getting squares on people sometimes in firefox |
|
|
|
yeah, i noticed that too, not sure what more we can do, any ideas? in the meantime, merge? |
|
I think the multiple clip-paths for each node may just overload it? Perhaps extract the node sizes, then create just a few clip-paths? |
|
each clip path is specific to each node, as it includes position as well as size, so we can't extract general clip paths. also notice if you reload a page in FF, all the initial clip paths will work fine, it's only when you navigate to new routes that some won't work. |
|
Idea: Its possible we could fix this by simply using html elements instead of svg. Lines and arrows can be drawn with css http://www.monkeyandcrow.com/samples/css_lines/. This could clear up the hacky bits of using svg with react (and enable fancy context-maintaining transitions between view-states:) |
