Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visible style option for simple plotly/bokeh plots. #3948

Merged
merged 2 commits into from
Sep 10, 2019

Conversation

jonmmease
Copy link
Collaborator

Setting visible to False will fully hide the individual element trace.

This option is very useful for the linked selection effort...

Setting to False will fully hide the individual trace
@jbednar
Copy link
Member

jbednar commented Sep 7, 2019

Is there a chance to unify this API with Bokeh?

@jonmmease
Copy link
Collaborator Author

Is there a chance to unify this API with Bokeh?

I'm not sure. Does anyone know if Bokeh plot elements have an equivalent property to hide everything? For the selection work I'm using the opacity style options to do this.

@jbednar
Copy link
Member

jbednar commented Sep 7, 2019

I'm not an expert at it, but Bokeh has a variety of related options like muted_alpha, muted_color, selection_glyph.visible, nonselection_glyph.visible, and so on; @philippjfr may be able to chat about it on Monday at see where things line up between the two backends.

@philippjfr
Copy link
Member

I'm not sure. Does anyone know if Bokeh plot elements have an equivalent property to hide everything?

Most bokeh elements indeed have a visible property and we should expose it.

@jonmmease
Copy link
Collaborator Author

Most bokeh elements indeed have a visible property and we should expose it.

Ok, thanks. I'll take a look

@jonmmease
Copy link
Collaborator Author

Alright, I added the visible style property to all of the simple (non-composite) Bokeh element plots. Basically, for all of the cases where all that is needed is to pass the property along to the single Bokeh glyph representing the element. I didn't do anything with the composite Bokeh elements to this point, as these will take some actual logic changes.

Sound alright for now?

@jonmmease jonmmease changed the title Plotly: Add visible style option for trace-based plotly plots. Add visible style option for simple plotly/bokeh plots. Sep 10, 2019
@philippjfr
Copy link
Member

Sound alright for now?

Yes, absolutely.

@jbednar
Copy link
Member

jbednar commented Sep 10, 2019

Great!

@philippjfr philippjfr merged commit a977c3d into master Sep 10, 2019
@jonmmease jonmmease deleted the plotly_visible branch September 10, 2019 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants