Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure plot minimum span causes RangeXY dependent operations to recompute #4087

Merged
merged 6 commits into from
Nov 6, 2019
Merged

Ensure plot minimum span causes RangeXY dependent operations to recompute #4087

merged 6 commits into from
Nov 6, 2019

Conversation

jbednar
Copy link
Member

@jbednar jbednar commented Nov 6, 2019

Fixes #4086 .

@philippjfr philippjfr changed the title Set ranges for hv.operation.datashader for points on a horiz/vert line Ensure plot minimum span causes RangeXY dependent operations to recompute Nov 6, 2019
@jbednar
Copy link
Member Author

jbednar commented Nov 6, 2019

Thanks. A lot more complex than my version, but seems to work the same for the test cases I had.

@philippjfr
Copy link
Member

Thanks. A lot more complex than my version, but seems to work the same for the test cases I had.

True, but it will now correctly respect the default_span plot option. In theory I should also trigger a recompute if padding is enabled but I might leave that for later.

@philippjfr philippjfr merged commit 33519de into master Nov 6, 2019
@philippjfr philippjfr deleted the fix_ds_horiz_vert branch January 9, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippjfr philippjfr Awaiting requested review from philippjfr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Datashading a vertical or horizontal line created with Holoviews Curve generates empty plot
2 participants
@jbednar @philippjfr