Cleaned up and improved legend handling for all backends #434
Conversation
|
This PR is now ready. While not perfect, legend behavior should now be much more consistent and I've tidied up the matplotlib implementation a little bit. |
| @@ -264,6 +264,9 @@ class SpikesPlot(PathPlot): | |||
| position = param.Number(default=0., doc=""" | |||
| The position of the lower end of each spike.""") | |||
|
|
|||
| show_legend = param.Boolean(default=True, doc=""" | |||
There was a problem hiding this comment.
This is a parameter available for the matplotlib backend IIRC. In which case, it is good to see this support added to the Bokeh backend.
There was a problem hiding this comment.
It's always been there I'm just being explicit about which plots have it enabled and disabled by default.
|
Looks good and I am happy to merge. This is the first PR to use the new documentation building system. I'm really happy with how easy it was to update the reference data for this PR. Note that when I click merge, this should trigger a merge hook but this will be the first time it is tested - we may have a failure on master if something goes wrong with the test data update. |
Cleaned up and improved legend handling for all backends
As the title suggests this is a refactor of the legend code so that a) it behaves more similarly across backends and b) to clean up the code a little bit.
Concretely this PR addresses the following issues: