Renamed DynamicMap 'closed' mode to 'bounded' #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mathematically 'closed' and 'open' isn't the same as 'bounded' and 'unbounded'. I've left 'open mode' alone as I think 'unbounded' is too long and 'open' has fairly natural semantics (as opposed to 'closed' versus 'bounded'). @jbednar @philippjfr Any thoughts on this? This is our last chance to change it! I think 'counter' mode is unproblematic unless you feel there is something better. Maybe 'step' mode? |
|
Sounds clearer to me and there isn't much backward compatibility to worry about. I'll merge unless @jbednar raises any objections in the next few minutes. |
|
Yes, please merge as I have another PR that will operate on the same file. |
|
Okay, too late for objections :) I'll merge |
philippjfr
added a commit
that referenced
this pull request
Feb 10, 2016
Renamed DynamicMap 'closed' mode to 'bounded'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR title says it all.
As far as I know, we are aware of (and can update) all code that may have used
DynamicMapup until this point...