Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed DynamicMap 'closed' mode to 'bounded' #485

Merged
merged 1 commit into from Feb 10, 2016
Merged

Conversation

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Feb 9, 2016

PR title says it all.

As far as I know, we are aware of (and can update) all code that may have used DynamicMap up until this point...

@jlstevens
Copy link
Contributor Author

@jlstevens jlstevens commented Feb 9, 2016

Mathematically 'closed' and 'open' isn't the same as 'bounded' and 'unbounded'. I've left 'open mode' alone as I think 'unbounded' is too long and 'open' has fairly natural semantics (as opposed to 'closed' versus 'bounded').

@jbednar @philippjfr Any thoughts on this? This is our last chance to change it! I think 'counter' mode is unproblematic unless you feel there is something better. Maybe 'step' mode?

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Feb 10, 2016

Sounds clearer to me and there isn't much backward compatibility to worry about. I'll merge unless @jbednar raises any objections in the next few minutes.

@jlstevens
Copy link
Contributor Author

@jlstevens jlstevens commented Feb 10, 2016

Yes, please merge as I have another PR that will operate on the same file.

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Feb 10, 2016

Okay, too late for objections :) I'll merge

philippjfr added a commit that referenced this pull request Feb 10, 2016
Renamed DynamicMap 'closed' mode to 'bounded'
@philippjfr philippjfr merged commit 06a64e1 into master Feb 10, 2016
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.0%) to 69.458%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@jlstevens jlstevens deleted the closed_to_bounded branch Feb 10, 2016
@philippjfr philippjfr added this to the 1.4.3 milestone Feb 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants