Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow tiles to be objects as well as strings #345

Merged
merged 2 commits into from
Oct 17, 2019
Merged

Allow tiles to be objects as well as strings #345

merged 2 commits into from
Oct 17, 2019

Conversation

jsignell
Copy link
Member

I was surprised that this wasn't already allowed.

@jsignell
Copy link
Member Author

Which doesn't necessarily mean it's a good idea.

@philippjfr
Copy link
Member

I think it's a good idea, oversight on my part. I'd definitely expect this to work.

@philippjfr philippjfr merged commit 4ceb21c into master Oct 17, 2019
@jsignell jsignell deleted the jsignell/tiles branch October 17, 2019 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippjfr philippjfr Awaiting requested review from philippjfr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsignell @philippjfr