Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass clim to opts #492

Closed
wants to merge 3 commits into from
Closed

Pass clim to opts #492

wants to merge 3 commits into from

Conversation

ahuang11
Copy link
Collaborator

@jlstevens
Copy link
Collaborator

Looks good to me! I don't think there is any reason that clims shouldn't be passed through and respected.

@philippjfr Seems like a simple fix. Any reason not to merge?

@aaronspring
Copy link
Contributor

Can this PR merge? Still very interested in the feature

@jlstevens
Copy link
Collaborator

I imagine this can be merged when the tests pass as the diff is short and simple. From what I can tell at a glance, the test failures are unrelated so maybe a rebase might fix things?

@aaronspring
Copy link
Contributor

Could you please rebase @ahuang11 or shall I open a new PR?

@aaronspring aaronspring mentioned this pull request Apr 9, 2021
Merged
@philippjfr philippjfr closed this Apr 14, 2021
@maximlt maximlt deleted the contours_clim branch November 18, 2021 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahuang11 @jlstevens @aaronspring @philippjfr