Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving the hvPlot UI #651

Merged
merged 3 commits into from
Jan 20, 2022
Merged

Improving the hvPlot UI #651

merged 3 commits into from
Jan 20, 2022

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Aug 16, 2021

This PR is working towards getting the hvPlot UI into a state where we can release it.

  • Separate DataFrame, Geometry and Gridded explorers while keeping hvPlotExplorer base class
  • Expose all axis options
  • Expose all style options
  • Expose all geo options
  • Expose all datashader options
  • Expose all style mapping options

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.3%) to 66.521% when pulling a8e380b on ui_improvements into 00e1ceb on master.

cls = hvGridExplorer
else:
cls = hvDataFrameExplorer
return cls(data, **params)
Copy link
Member

@jbednar jbednar Aug 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code answers my immediate reaction to "Separate DataFrame, Geometry and Gridded explorers while keeping hvPlotExplorer base class", i.e., to ask for a factory that returns something of the correct type. One step ahead of me!

Still, if hvGeomExplorer is not a subclass of hvDataFrameExplorer, it seems problematic to switch between those two here. Conceptually, can't any dataframe become a geo dataframe by tacking on a geometry column? And so shouldn't the capabilities of hvGeomExplorer include all the capabilities of hvDataFrameExplorer, plus a few geo-related ones? I can't tell much from the implementations of these two classes about what their future is, but it seems at first glance that people could add functionality to hvDataFrameExplorer that would then not be available in hvGeomExplorer, which doesn't seem right to me.

@philippjfr philippjfr merged commit 1c35fdb into master Jan 20, 2022
@maximlt maximlt deleted the ui_improvements branch January 28, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants