Improving the hvPlot UI#651
Conversation
| cls = hvGridExplorer | ||
| else: | ||
| cls = hvDataFrameExplorer | ||
| return cls(data, **params) |
There was a problem hiding this comment.
This code answers my immediate reaction to "Separate DataFrame, Geometry and Gridded explorers while keeping hvPlotExplorer base class", i.e., to ask for a factory that returns something of the correct type. One step ahead of me!
Still, if hvGeomExplorer is not a subclass of hvDataFrameExplorer, it seems problematic to switch between those two here. Conceptually, can't any dataframe become a geo dataframe by tacking on a geometry column? And so shouldn't the capabilities of hvGeomExplorer include all the capabilities of hvDataFrameExplorer, plus a few geo-related ones? I can't tell much from the implementations of these two classes about what their future is, but it seems at first glance that people could add functionality to hvDataFrameExplorer that would then not be available in hvGeomExplorer, which doesn't seem right to me.
fd3c372 to
c1850ab
Compare
This PR is working towards getting the hvPlot UI into a state where we can release it.
hvPlotExplorerbase class