Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Add support for planar layout from NX #700

Merged
merged 4 commits into from
Jan 26, 2022

Conversation

MridulS
Copy link
Contributor

@MridulS MridulS commented Jan 24, 2022

Added support for nx.draw_planar convenience function and an example to the User guide.

Wasn't sure how to test this, let me know if I anything else is required :)

@maximlt
Copy link
Member

maximlt commented Jan 24, 2022

Hey thanks @MridulS for the PR!

I don't think it's documented anywhere (while it should!) but there's a little script we run on a notebook before committing any change to strip its metadata. You need to have jq installed on your system:

#!/bin/bash

jq --sort-keys --indent 1 \
    '
    (.cells[] | select(has("outputs")) | .outputs) = []
    | (.cells[] | select(has("execution_count")) | .execution_count) = null
    | .metadata = {"language_info": {"name":"python", "pygments_lexer": "ipython3"}}
    | .cells[].metadata = {}
    | del(.cells[].id)
    ' "$1" > /tmp/$(basename $1) && cat /tmp/$(basename $1) > "$1"

Otherwise your PR looks good to me.

Copy link
Member

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, once the metadata is cleared and the tests pass. Thanks!

@MridulS
Copy link
Contributor Author

MridulS commented Jan 24, 2022

The 2.7 failure was unrelated from this change, should be fixed by e82b953 .

@MridulS
Copy link
Contributor Author

MridulS commented Jan 25, 2022

#651 has a couple of py3 specific syntax (numeric underscores and f strings).
Is it time to drop py2.7 support?

@philippjfr
Copy link
Member

I'd be happy to drop py2.7 as part of the 0.8 release tbh.

@MridulS
Copy link
Contributor Author

MridulS commented Jan 26, 2022

This should be ready to merge then :)

@philippjfr philippjfr merged commit 7864275 into holoviz:master Jan 26, 2022
@philippjfr
Copy link
Member

Thanks @MridulS!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants