-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Add support for planar layout from NX #700
Conversation
Hey thanks @MridulS for the PR! I don't think it's documented anywhere (while it should!) but there's a little script we run on a notebook before committing any change to strip its metadata. You need to have #!/bin/bash
jq --sort-keys --indent 1 \
'
(.cells[] | select(has("outputs")) | .outputs) = []
| (.cells[] | select(has("execution_count")) | .execution_count) = null
| .metadata = {"language_info": {"name":"python", "pygments_lexer": "ipython3"}}
| .cells[].metadata = {}
| del(.cells[].id)
' "$1" > /tmp/$(basename $1) && cat /tmp/$(basename $1) > "$1" Otherwise your PR looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, once the metadata is cleared and the tests pass. Thanks!
The 2.7 failure was unrelated from this change, should be fixed by e82b953 . |
#651 has a couple of py3 specific syntax (numeric underscores and f strings). |
I'd be happy to drop py2.7 as part of the 0.8 release tbh. |
This should be ready to merge then :) |
Thanks @MridulS! |
Added support for nx.draw_planar convenience function and an example to the User guide.
Wasn't sure how to test this, let me know if I anything else is required :)