Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep SQL in memory #553

Merged
merged 21 commits into from
May 15, 2024
Merged

Keep SQL in memory #553

merged 21 commits into from
May 15, 2024

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented May 13, 2024 •
edited

I believe the model is capable of modifying the SQL better if it's not popped from memory every time.

Also, offer more context for the assistant to judge whether the table is still relevant by providing column names.

Still can't get joined tables working:

2024-05-13 13:34:26,944 'Pipeline._update_data' raised CatalogException: Catalog Error: Table with name nino_oni does not exist!
Did you mean "pg_am"?
LINE 1: ...read_parquet('tc_tracks.parquet') JOIN nino_oni ON strftime('%Y', tc_tracks.is...

@ahuang11 ahuang11 requested a review from philippjfr May 13, 2024 20:36
@ahuang11 ahuang11 changed the base branch from main to lumen_ai May 13, 2024 20:36
@ahuang11 ahuang11 changed the base branch from lumen_ai to fuzzy_table_matching May 13, 2024 20:36
Base automatically changed from fuzzy_table_matching to lumen_ai May 14, 2024 12:09
@philippjfr
Copy link
Member

I think messed up the merge.

@ahuang11
Copy link
Contributor Author

It looks okay I think.

@ahuang11
Copy link
Contributor Author

Oh yeah, some parts were re-added in.

@ahuang11
Copy link
Contributor Author

Should this go in too or is it missing something

@philippjfr philippjfr merged commit bfed304 into lumen_ai May 15, 2024
1 of 11 checks passed
@philippjfr philippjfr deleted the keep_sql branch May 15, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippjfr philippjfr Awaiting requested review from philippjfr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ahuang11 @philippjfr