Skip to content

Commit

Permalink
Skip version check if version is None (#1613)
Browse files Browse the repository at this point in the history
* Skip version check if version is None

* Pin IPython

* Disable patch commit status
  • Loading branch information
philippjfr committed Oct 6, 2020
1 parent 04b618a commit a29107d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
1 change: 1 addition & 0 deletions codecov.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
coverage:
status:
patch: off
project:
default:
target: auto
Expand Down
5 changes: 3 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,8 @@ def run(self):
'folium',
'ipympl',
'twine',
'pandas<1.1' # temporary fix for streamz incompatibility
'pandas<1.1', # temporary fix for streamz incompatibility
'ipython >=7.0'
]

extras_require = {
Expand Down Expand Up @@ -227,7 +228,7 @@ def run(self):
with open('./panel/package.json') as f:
package_json = json.load(f)
js_version = package_json['version']
if version.split('+')[0] != js_version.replace('-', ''):
if version != 'None' and version.split('+')[0] != js_version.replace('-', ''):
raise ValueError("panel.js version (%s) does not match "
"panel version (%s). Cannot build release."
% (js_version, version))
Expand Down

0 comments on commit a29107d

Please sign in to comment.