Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VTK] optional interactive orientation widget #1635

Merged
merged 5 commits into from
Oct 15, 2020

Conversation

xavArtley
Copy link
Collaborator

following #1602 discussion I add a parameter to make the orientation widget interactive optional

By default the interactive_orientation_widget is True except for VTKRenderWindowSynchronized class where errors occur when we try to synchrnonize the view. I let the possibility to set it to true but in this case a warning is raised.

With this modification I updated the vtkjs to the latest version, it allows me to remove 2 files which were reimplementation of vtkjs corrections

@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #1635 into master will increase coverage by 0.07%.
The diff coverage is 54.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1635      +/-   ##
==========================================
+ Coverage   85.40%   85.47%   +0.07%     
==========================================
  Files         147      147              
  Lines       16717    16859     +142     
==========================================
+ Hits        14277    14411     +134     
- Misses       2440     2448       +8     
Impacted Files Coverage Δ
panel/pane/vtk/vtk.py 93.84% <44.44%> (-0.37%) ⬇️
panel/models/vtk.py 100.00% <100.00%> (ø)
setup.py 0.00% <0.00%> (ø)
panel/tests/widgets/test_indicators.py 100.00% <0.00%> (ø)
panel/viewable.py 73.19% <0.00%> (+0.23%) ⬆️
panel/widgets/indicators.py 95.38% <0.00%> (+2.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4f5b15...ab58048. Read the comment docs.

@xavArtley
Copy link
Collaborator Author

xavArtley commented Oct 15, 2020

In the same time I added some corrections about the camera property state change
before corrections:
tet_old
tet2_old

after corrections
2tet
tet2

@philippjfr
Copy link
Member

Looks good thanks! Can you document the parameter in the reference notebook?

@philippjfr philippjfr merged commit 99004f5 into master Oct 15, 2020
@philippjfr philippjfr deleted the xav/vtk_optional_interactive_orientation_widget branch October 15, 2020 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants