Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Location sync serialization #1792

Merged
merged 5 commits into from
Nov 17, 2020
Merged

Fix Location sync serialization #1792

merged 5 commits into from
Nov 17, 2020

Conversation

philippjfr
Copy link
Member

Fixes #1784

Cc: @hoxbro Sorry for closing your PR but using param serialization correctly is non-obvious so this was going to result in a quicker turnaround.

@hoxbro
Copy link
Member

hoxbro commented Nov 17, 2020

No problem. I was suspecting that there were a better way.

I also hope it is okay that I was "half-fixing" a problem like this, to be better to understand the underlying framework.

@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #1792 (0d6e1a7) into master (f22e267) will increase coverage by 0.00%.
The diff coverage is 83.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1792   +/-   ##
=======================================
  Coverage   85.13%   85.13%           
=======================================
  Files         151      151           
  Lines       17923    17936   +13     
=======================================
+ Hits        15258    15270   +12     
- Misses       2665     2666    +1     
Impacted Files Coverage Δ
panel/io/location.py 85.24% <83.33%> (+0.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f22e267...0d6e1a7. Read the comment docs.

@philippjfr
Copy link
Member Author

Note this actually causes another regression because param serialization of tuples was broken, see holoviz/param#446

@philippjfr philippjfr merged commit 0092a1a into master Nov 17, 2020
@philippjfr philippjfr deleted the 1784_fix_sync branch November 17, 2020 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Location sync broken for dates, ints
2 participants