Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel 0.11.0rc4: Auto Reload- Should not get a module_name not in sys.modules #2032

Merged
merged 2 commits into from
Feb 27, 2021

Conversation

MarcSkovMadsen
Copy link
Collaborator

I'm using panel serve with the --auto flag on awesome-panel locally. When I edit the awesome-panel package (an external package which is installed via pip install -e) I get the below error

 File "c:\repos\private\awesome-panel\.venv\lib\site-packages\tornado\ioloop.py", line 905, in _run
    return self.callback()
  File "c:\repos\private\awesome-panel\.venv\lib\site-packages\panel\io\callbacks.py", line 70, in _periodic_callback
    self.callback()
  File "c:\repos\private\awesome-panel\.venv\lib\site-packages\panel\io\reload.py", line 140, in _reload_on_update
    module = sys.modules[module_name]
KeyError: 'awesome_panel'

This provides a fix.

@MarcSkovMadsen MarcSkovMadsen changed the title Auto Reload: Don' try to get a module not in sys.modules Panel 0.11.0rc4: Auto Reload- Should not get a module_name not in sys.modules Feb 27, 2021
@codecov
Copy link

codecov bot commented Feb 27, 2021

Codecov Report

Merging #2032 (84786b8) into master (6f78a5a) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2032      +/-   ##
==========================================
- Coverage   84.26%   84.26%   -0.01%     
==========================================
  Files         176      176              
  Lines       20502    20504       +2     
==========================================
  Hits        17277    17277              
- Misses       3225     3227       +2     
Impacted Files Coverage Δ
panel/io/reload.py 66.66% <0.00%> (-1.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f78a5a...84786b8. Read the comment docs.

@philippjfr philippjfr merged commit bea0326 into master Feb 27, 2021
@philippjfr philippjfr deleted the dont-reload-external-module branch February 27, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants