Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure update to ReactiveData value sets correct old value on event #3308

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

philippjfr
Copy link
Member

Fixes #3188

@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #3308 (eb839f8) into master (80d90ee) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3308      +/-   ##
==========================================
+ Coverage   83.39%   83.40%   +0.01%     
==========================================
  Files         196      196              
  Lines       26509    26509              
==========================================
+ Hits        22108    22111       +3     
+ Misses       4401     4398       -3     
Impacted Files Coverage Δ
panel/reactive.py 77.60% <100.00%> (+0.22%) ⬆️
panel/widgets/tables.py 87.88% <0.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80d90ee...eb839f8. Read the comment docs.

@philippjfr philippjfr merged commit bc999f4 into master Apr 4, 2022
@philippjfr philippjfr deleted the tables_event_old_new branch April 4, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Watching the tabulator value returns the same old and new event attributes
1 participant