Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not recompute data when local pagination is enabled #3854

Merged
merged 3 commits into from Sep 16, 2022

Conversation

philippjfr
Copy link
Member

Previously we re-computed the data, style and selections when pagination options changed on local pagination. This is not necessary and was causing issues when header filters were applied.

@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Merging #3854 (7847ff8) into master (77943b1) will decrease coverage by 0.02%.
The diff coverage is 28.57%.

❗ Current head 7847ff8 differs from pull request most recent head 07b0522. Consider uploading reports for the commit 07b0522 to get more accurate results

@@            Coverage Diff             @@
##           master    #3854      +/-   ##
==========================================
- Coverage   75.24%   75.21%   -0.03%     
==========================================
  Files         224      224              
  Lines       32681    32699      +18     
==========================================
+ Hits        24591    24595       +4     
- Misses       8090     8104      +14     
Flag Coverage Δ
unitexamples-tests 75.21% <28.57%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/tests/ui/widgets/test_tabulator.py 9.46% <13.33%> (+<0.01%) ⬆️
panel/widgets/tables.py 87.31% <66.66%> (+<0.01%) ⬆️
panel/io/reload.py 69.56% <0.00%> (-2.18%) ⬇️
panel/io/cache.py 81.98% <0.00%> (-0.46%) ⬇️
panel/io/server.py 74.65% <0.00%> (-0.20%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit e44b1dc into master Sep 16, 2022
@philippjfr philippjfr deleted the local_pagination_filter_not_reapplied branch September 16, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant