Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bundling of shared resources #3894

Merged
merged 2 commits into from
Sep 27, 2022
Merged

Add bundling of shared resources #3894

merged 2 commits into from
Sep 27, 2022

Conversation

philippjfr
Copy link
Member

Bundle jQuery, Bootstrap and Font-Awesome once and share it across all models and templates.

Also adds various UI tests ensuring that no console errors indicating missing resources appear.

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #3894 (0552659) into master (ebfce28) will decrease coverage by 8.24%.
The diff coverage is 34.82%.

@@            Coverage Diff             @@
##           master    #3894      +/-   ##
==========================================
- Coverage   83.19%   74.95%   -8.25%     
==========================================
  Files         217      222       +5     
  Lines       32529    32714     +185     
==========================================
- Hits        27064    24522    -2542     
- Misses       5465     8192    +2727     
Flag Coverage Δ
ui-tests ?
unitexamples-tests 74.95% <34.82%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/io/notifications.py 64.04% <ø> (-0.40%) ⬇️
panel/compiler.py 6.22% <5.26%> (-0.08%) ⬇️
panel/tests/ui/widgets/test_tabulator.py 9.46% <11.11%> (-89.49%) ⬇️
panel/tests/ui/template/test_fastlisttemplate.py 28.57% <14.28%> (-71.43%) ⬇️
panel/tests/ui/pane/test_plotly.py 30.69% <22.22%> (-67.14%) ⬇️
panel/tests/ui/template/test_fastgridtemplate.py 28.57% <28.57%> (ø)
panel/tests/ui/template/test_bootstraptemplate.py 29.62% <29.62%> (ø)
panel/tests/ui/template/test_materialtemplate.py 29.62% <29.62%> (ø)
panel/tests/ui/pane/test_perspective.py 46.66% <46.66%> (ø)
panel/tests/ui/pane/test_vega.py 46.66% <46.66%> (ø)
... and 36 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 3178f19 into master Sep 27, 2022
@philippjfr philippjfr deleted the bundle_shared_resources branch September 27, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant