Resolving design modifiers based on the theme type #4978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well I should have ran the tests locally first! It seems like this change broke a few things. Marking the PR as draft. |
|
Suspect sometimes the theme is passed in as the type and sometimes as the instance, so it just needs an isinstance check. |
philippjfr
reviewed
May 31, 2023
philippjfr
force-pushed
the
fix_cache_modifiers
branch
from
855e17d
to
2c9525c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4978 +/- ##
===========================================
+ Coverage 22.35% 84.44% +62.09%
===========================================
Files 299 299
Lines 44647 44680 +33
===========================================
+ Hits 9980 37730 +27750
+ Misses 34667 6950 -27717
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
philippjfr
approved these changes
May 31, 2023
philippjfr
approved these changes
May 31, 2023
philippjfr
force-pushed
the
fix_cache_modifiers
branch
from
dd137de
to
7645f26
Compare
philippjfr
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this while trying out objgraph on a dummy app (to find a memory leak on a bigger app) and it proved useful as it detected that opening a new session of the same app generated some new
NativeDefaultThemeobjects that weren't cleaned up. This happened because_resolve_modifiers- which is decorated with@functools.lru_cache- was passed a new instance of the theme instead of its type, while I believe passing the type is enough (I haven't followed all the modifiers related code though).