Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only render Card contents when not collapsed #5786

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Oct 31, 2023

Ensures components which require DOM element to be attached can be rendered in Card.

Fixes bokeh/ipywidgets_bokeh#102

Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #5786 (418b164) into main (d26af81) will decrease coverage by 9.84%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5786      +/-   ##
==========================================
- Coverage   82.23%   72.39%   -9.84%     
==========================================
  Files         290      290              
  Lines       42161    42161              
==========================================
- Hits        34672    30524    -4148     
- Misses       7489    11637    +4148     
Flag Coverage Δ
ui-tests ?
unitexamples-tests 72.39% <ø> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 77 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 04e00f5 into main Oct 31, 2023
12 of 13 checks passed
@philippjfr philippjfr deleted the card_render_fix branch October 31, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ipywidgets not getting rendered in Panel accordion
1 participant