Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a somewhat complex app with Tabulator widgets nested in an Accordion that started to raise Javascript errors related to Panel's tabulator code. The error is raised from the last condition of the second line because
this.tabulator
isundefined
,setData
being called from the callback triggered bythis.model.source.properties.data.change
.panel/panel/models/tabulator.ts
Lines 904 to 905 in 6b6eb3f
It seems like this was the consequence of #5786. I haven't found what exactly can cause
this.tabulator
to be undefined in this context, so I'm just adding a guard in thethis.model.source.properties.data.change
callback and that seems to do the job.