Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preprocessing hook to link HoloViews plot axes across panel layout #586

Merged
merged 2 commits into from Aug 11, 2019

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Aug 9, 2019

As the title says. Should decide whether this should be the default and perhaps handle axiswise option on holoviews objects.

  • Add tests

@jbednar
Copy link
Member

@jbednar jbednar commented Aug 9, 2019

I vote for this being the default, and for supporting the option to disable it if needed.

@philippjfr philippjfr added the type: enhancement label Aug 11, 2019
@philippjfr philippjfr merged commit efb340e into master Aug 11, 2019
1 of 3 checks passed
@johnzzzzzzz
Copy link

@johnzzzzzzz johnzzzzzzz commented Aug 19, 2019

I would vote to follow the defaults for the underlying library.
In the case of Holoviews, the axes seem shared by defualt for each axes kind, i.e when two plots share the same underlying column for the x axis.

For example, if the shared data has columns: time, q, z1, z2.
Then the plots for time vs z1 and time vs z1 would share axes AND for the same layout, plots for q vs z1 and q vs z2 would share their (different) axes.

@philippjfr philippjfr deleted the philippfr/holoviews_linked_axes branch Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants