Allow passing partial function to tabulator filter #5912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible to pass a function as a filter to tabulator but passing a functools.partial function currently fails. This update allows to pass both regular and partial function
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5912 +/- ##
==========================================
- Coverage 82.58% 82.57% -0.01%
==========================================
Files 291 291
Lines 42786 42786
==========================================
- Hits 35335 35331 -4
- Misses 7451 7455 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
philippjfr
approved these changes
Nov 23, 2023
|
Thanks for your contribution @TBym! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to pass a function as a filter to Tabulator but passing a functools.partial function currently fails. This update allows to pass both regular and partial functions.