Ensure that Design does not override properties on HoloViews pane #6051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6051 +/- ##
==========================================
+ Coverage 84.66% 84.68% +0.01%
==========================================
Files 291 291
Lines 43816 43834 +18
==========================================
+ Hits 37099 37119 +20
+ Misses 6717 6715 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue reported in #6026 where applying a Design to a HoloViews pane would override any properties that are specific to the underlying plot pane, e.g. the
Plotlypane applies a custom stylesheet to fix the toolbar in a shadow DOM context, this was lost because the Design would ask the HoloViews pane to process the overridden defaults which did not know about any custom stylesheets that thePlotlypane applied.