Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the user experience for resetting Jupyterlite. #6198

Merged
merged 2 commits into from
Jan 14, 2024

Conversation

MarcSkovMadsen
Copy link
Collaborator

@MarcSkovMadsen MarcSkovMadsen commented Jan 14, 2024

I just discovered by coincidence that the Getting_Started notebook in Panelite now contains functionality to reset. This is great.

I think the functionality can improved

  • Make it more easily discoverable by putting in separate, clearly named notebook.
  • Avoid having to import, run and scroll down. This is slow. This can be avoided by putting it in separate notebook. (Yes. I know you don't have to import and run. But its just a very natural thing to do).
  • Send a clear signal that the storage has been cleared. Today when you click the button nothing visible happens. Thus you don't feel confident that the script finished with success.

Furthermore as a developer

  • I cannot find the Getting_Start.ipynb notebook via my IDE because its actually ignored in the gitignore. So its simply excluded by VS code.
  • I do not get the notebook cleaned when I use pre-commit because its actually skipped in the configuration.

This PR fixes these issues.

image

Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thanks!

@philippjfr philippjfr merged commit 4bc5fab into main Jan 14, 2024
6 checks passed
@philippjfr philippjfr deleted the enhancement/reset-jupyterlite-experience branch January 14, 2024 11:12
@philippjfr philippjfr modified the milestones: next, v1.4.0 Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants