Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow providing additional stylesheets in card_params #6242

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

philippjfr
Copy link
Member

Fixes #6240

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (00a45d7) 22.29% compared to head (1e2d3bb) 84.15%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6242       +/-   ##
===========================================
+ Coverage   22.29%   84.15%   +61.85%     
===========================================
  Files         301      301               
  Lines       45118    45123        +5     
===========================================
+ Hits        10061    37975    +27914     
+ Misses      35057     7148    -27909     
Flag Coverage Δ
ui-tests 40.69% <0.00%> (?)
unitexamples-tests 71.83% <100.00%> (+49.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 063a514 into main Jan 19, 2024
14 of 15 checks passed
@philippjfr philippjfr deleted the card_params_override branch January 19, 2024 12:53
philippjfr added a commit that referenced this pull request Jan 19, 2024
* Allow providing additional stylesheets in card_params

* Do not override stylesheets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend chatfeed card stylesheets through card_params
1 participant