Improve documentation on TextAreaInput #6264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6264 +/- ##
===========================================
- Coverage 82.68% 71.78% -10.90%
===========================================
Files 301 301
Lines 45099 45200 +101
===========================================
- Hits 37288 32446 -4842
- Misses 7811 12754 +4943
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
maximlt
approved these changes
Jan 23, 2024
philippjfr
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6246 (comment)
Added mention of default, an example, and
enable readonly=True.Okay readonly doesn't initialize.Unsure how to remove / disable resizable from the jslink side since it can't be set after it has been initialized.
I can't even find resizable on Bokeh's TextAreaInput:
https://github.com/bokeh/bokeh/blob/4b61612d14f840b990a74e455d49feb012badc12/bokehjs/src/lib/models/widgets/textarea_input.ts#L41
Only https://github.com/bokeh/bokeh/blob/4b61612d14f840b990a74e455d49feb012badc12/src/bokeh/models/layouts.py#L287-L289
But it works
Screen.Recording.2024-01-23.at.7.31.05.AM.mov