Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dynamically setting header in ChatFeed #6441

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented Mar 5, 2024

Allow dynamically setting header.

@ahuang11 ahuang11 requested a review from philippjfr March 5, 2024 19:44
@ahuang11 ahuang11 changed the title Fix update header Fix dynamically setting header in ChatFeed Mar 5, 2024
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.68%. Comparing base (6608244) to head (086f3d5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6441      +/-   ##
==========================================
+ Coverage   82.07%   83.68%   +1.60%     
==========================================
  Files         310      310              
  Lines       45920    45927       +7     
==========================================
+ Hits        37691    38433     +742     
+ Misses       8229     7494     -735     
Flag Coverage Δ
ui-tests 39.83% <14.28%> (+3.25%) ⬆️
unitexamples-tests 71.62% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 40a6459 into main Mar 6, 2024
14 of 15 checks passed
@philippjfr philippjfr deleted the fix_update_header branch March 6, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants